[TC 11.00rc2] Pressing + and - in Background Transfer Manager

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5174
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *white »

Setup for testing:
  1. Select a file
  2. Open menu option Commands/Background Transfer Manager
  3. Click the Pause button
  4. Click + and add selected file for copying
  5. Repeat step 4 one or more times (the same operation is fine)
  6. Select one of the lines in the queue
Now press the Tab key repeatedly until the option "Speed limit" has focus. If you press + then the option "Speed limit" is enabled and the + button is executed. If you press - the option is disabled and the - button is executed.

Press the Tab key repeatedly until the editbox for entering the speed has focus. Something similar as above happens here when pressing + or -.

Pressing + and - work similar to access keys, but not quite, which creates problems. I think they should behave like access keys, meaning the focus should be placed on the + or - button and then the action of he button should be executed.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *ghisler(Author) »

OK, I will ignore + and - when pressed on the checkbox or in the edit box. Instead I will support Alt+"+", Alt+"-" and Ctrl+"+" and Ctrl+"-".
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5174
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *white »

HISTORY.TXT wrote: 21.07.23 Fixed: Background transfer manager: Don't use "+" and "-" to add/remove files when the focus is on the checkbox or edit box. Instead, use Alt or Ctrl with these keys (32/64)
Tested using TC 11.00rc3. It works, but why is there a beep when using Alt with the keys?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *ghisler(Author) »

I don't know, I'm not generating it myself in code.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *ghisler(Author) »

I found a solution, I have to handle message WM_SYSCHAR to prevent the beep.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15479
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *petermad »

2ghisler(Author)
I have to handle message WM_SYSCHAR to prevent the beep
Could that also be used for this unwanted beep: https://ghisler.ch/board/viewtopic.php?p=438089#p438089 :?:
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *ghisler(Author) »

No, there I had to return 1 when handling WM_CHAR sending the space.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15479
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *petermad »

history.txt wrote:31.07.23 Fixed: Background transfer manager: Prevent beep when pressing Tab or Shift+Tab in edit control by handling WM_CHAR (32/64)
27.07.23 Fixed: Background transfer manager: Prevent beep when pressing Alt+"+" or Alt+"-" by handling WM_SYSCHAR (32/64)
Confirmed fixed in private TC 11.00rc3a :-)

The Tab-beep only occurred when entering and leaving the Max. speed input field.
License #524 (1994)
Danish Total Commander Translator
TC 11.50b4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1383a
TC 3.60b4 on Android 6, 13 & 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 49100
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *ghisler(Author) »

The Tab-beep only occurred when entering and leaving the Max. speed input field.
Yes, that's what I meant with edit control, it's the only edit control in the background transfer manager.
Author of Total Commander
https://www.ghisler.com
User avatar
AntonyD
Power Member
Power Member
Posts: 1376
Joined: 2006-11-04, 15:30 UTC
Location: Russian Federation

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *AntonyD »

If it's really fixed - so move the topic to Fixed?
#146217 personal license
User avatar
white
Power Member
Power Member
Posts: 5174
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.00rc2] Pressing + and - in Background Transfer Manager

Post by *white »

Tested OK using TC 11.00 final.

Moderator message from: white » 2023-08-02, 17:31 UTC

Moved to Fixed bugs.
Post Reply