crc check bug

English support forum

Moderators: Hacker, petermad, Stefan2, white

Post Reply
fejesjoco
New Member
New Member
Posts: 1
Joined: 2004-02-20, 23:08 UTC

crc check bug

Post by *fejesjoco »

let's suppose i make SFV or MD5 files but not with the extension .sfv. then if i select the crc check menu command, it displays an error message that it can't identify the file, and doesn't even check its contents. i think it shouldn't rely on the file type, especially because unix systems also use md5 format and it doesn't always have an extension, or if it has, it's definitely not .sfv.
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

TC=Windows using---

Post by *Clo »

:) Hello!

• TC is not designed to verify the archives under UNIX...

• TC is a program working under Windows, which needs file-extensions for such functions.

• *.SFV or *.MD5 files can't be recognized without an extension.
* Currently, these files are created in the same directory than their relative archive.

• Most certainly, a *.SFV / *.MD5 file has the same name than its archive, but I guess isn't secure enough under Windows to know what it is...
• If you have some checksum files coming from UNIX, you could simply add the extension -I should be interested to hear how you could know the right one, without editing the file - :wink:

:mrgreen: Kind regards
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
Illuvatar
Junior Member
Junior Member
Posts: 2
Joined: 2004-11-29, 22:14 UTC

Post by *Illuvatar »

I can give a (late since i just found the problem myself) example where the current solution is REAAAALY BAAAD...

I have a CD with an md5sum.txt file on it... I can't rename it (can you rename files on an burnt CD ? :) ) but it's quite obvius that it's a list of md5 sums :)

The default UNIX filename for md5sum:s are md5sum (w/o any extension at all...

It would be much more logical to try to determine wheter it is an sfv or md5sum file by looking at the whole filename and conent (any file with two colums is a potential checksumfile) and when unable to automagically determine ask the user how to treat the file.
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

I have a CD with an md5sum.txt file on it... I can't rename it
But you could copy it to your hard drive and edit it. Shouldn't be that difficult to add something like d:\ at the beginning of each line.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
Sheepdog
Power Member
Power Member
Posts: 5150
Joined: 2003-12-18, 21:44 UTC
Location: Berlin, Germany
Contact:

Post by *Sheepdog »

Another way:

Make a new MD5 file with TC. Do a 'Compare by content' to find differences.

sheepdog
"A common mistake that people make when trying to design something
completely foolproof is to underestimate the ingenuity of complete fools."
Douglas Adams
Illuvatar
Junior Member
Junior Member
Posts: 2
Joined: 2004-11-29, 22:14 UTC

Post by *Illuvatar »

Hacker wrote:But you could copy it to your hard drive and edit it. Shouldn't be that difficult to add something like d:\ at the beginning of each line.

Roman
Yes. I did this, but it's the wrong solution...
Sheepdog wrote:Another way:

Make a new MD5 file with TC. Do a 'Compare by content' to find differences.

sheepdog
This only works if the files are formattet the same way (and files sorted in the same order)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

TC 6.5 will support md5sum.txt!
Author of Total Commander
https://www.ghisler.com
User avatar
Helix751
Senior Member
Senior Member
Posts: 241
Joined: 2004-06-16, 21:16 UTC
Location: Chile

Post by *Helix751 »

Wow! End Of Discussion :) Thanks Christian.

I would add that it would help a lot that the Verify Checksums window used colored text to display the OK/Failed files, like in the following example:

---
tadream2004-03-06d1.md5:
OK: tadream2004-03-06d1t01.shn
OK: tadream2004-03-06d1t02.shn
Wrong CRC: tadream2004-03-06d1t03.shn
OK: tadream2004-03-06d1t04.shn
OK: tadream2004-03-06d1t05.shn
OK: tadream2004-03-06d1t06.shn
Cannot open input file tadream2004-03-06d1t07.shn!
Cannot open input file tadream2004-03-06d1t08.shn!
OK: tadream2004-03-06d1t09.shn
OK: tadream2004-03-06d1t10.shn

Errors: 3 (Errors: 0 when no errors encountered)
OK: 7, not found: 2, read error: 0, wrong checksum: 1
---

This way, it would be much easier to spot an error/missing file in a large list of files.

Best regards,
Sergei
User avatar
djk
Power Member
Power Member
Posts: 1651
Joined: 2003-03-17, 11:33 UTC
Location: Poland
Contact:

Post by *djk »

2Villampiro
Yes, it would be much easier to see if the files are ok - one look and you see if there is red color or not.
Good idea.
DJK
Totally addicted to Total Commander
totalcmd.pl
en.totalcmd.pl
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

I support the colours !

Post by *Clo »

2Villampiro
:) Hello !
- I support this idea too !
{ Apart : everyone here knows I like colours ! }

:mrgreen: Kind regards,
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
titanium
Junior Member
Junior Member
Posts: 51
Joined: 2003-11-07, 10:37 UTC
Location: Israel

Post by *titanium »

Hello

I support the coloring idea. It will be of a great help.

I have another request: When the Verify CRC function is complete, double clicking a file will direct you to that file.

A more complicated idea is to implemet "feed to listbox" of the file list with a filter for OK files, Wrong CRC etc...

I hope my ideas will be considered by Christian.

Thanks :)
Post Reply