[Implemented in Tc11.03rc3} [Tc11] Suggestion: COMMANDER_INI_PATH
Moderators: Hacker, petermad, Stefan2, white
- ghisler(Author)
- Site Admin
- Posts: 50475
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
Then the same will occur in case of the %COMMANDER_PATH%, won't it?ghisler(Author) wrote: 2024-01-19, 07:58 UTC ...problem is that you can't use a backslash consistently when it's possible that the location is a drive root...
Nevertheless, %COMMANDER_PATH% does not include the terminal backslash.
So, regarding consistency, my vote goes, for one of the variables.
In other words, let them variables, %COMMANDER_PATH% and %COMMANDER_INI_PATH%, behave the same way.
Edit:
%COMMANDER_DRIVE% as well.
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10/15
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10/15
- ghisler(Author)
- Site Admin
- Posts: 50475
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
Of course, that shouldn't change under any circumstances. But %COMMANDER_INI_PATH% should look like %COMMANDER_PATH% otherwise there will just be endless stress...ghisler(Author) wrote: 2024-01-19, 09:51 UTC I will not change %COMMANDER_DRIVE% and %COMMANDER_PATH% because it would break existing configurations.
[edit]
"drive root" nobody does thatghisler(Author) wrote: 2024-01-19, 07:58 UTC I can change it, but the problem is that you can't use a backslash consistently when it's possible that the location is a drive root, e.g. on a USB flash drive.
[/edit]
Last edited by JOUBE on 2024-01-19, 10:53 UTC, edited 1 time in total.
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
2ghisler(Author)
Lol. I didn't imply changing %COMMANDER_DRIVE%, %COMMANDER_PATH%.
On the contrary, my idea is that %COMMANDER_INI_PATH% dealing with a similar entity is expected to follow the syntax of the two.
I.e. %COMMANDER_INI_PATH% is one to be changed.
%COMMANDER_DRIVE%, %COMMANDER_PATH% are going without trailing backslash -- %COMMANDER_INI_PATH% should follow the conception (to go without trailing backslash).
Lol. I didn't imply changing %COMMANDER_DRIVE%, %COMMANDER_PATH%.
On the contrary, my idea is that %COMMANDER_INI_PATH% dealing with a similar entity is expected to follow the syntax of the two.
I.e. %COMMANDER_INI_PATH% is one to be changed.
%COMMANDER_DRIVE%, %COMMANDER_PATH% are going without trailing backslash -- %COMMANDER_INI_PATH% should follow the conception (to go without trailing backslash).
#278521 User License
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10/15
Total Commander [always the latest version, including betas] x86/x64 on Win10 x64/Android 10/15
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
Says who? You might not even realize that it's the drive root, e.g. in case of substituted drives (subst command) or a mapped network drive (net use command). Sure, it's probably (very) rare, but I don't think it's too far fetched to say that it will happen to someone eventually.
Nonetheless I vote for consistency with existing variables. Even if a drive root adds a backslash automatically I don't see that as a problem because a path like G:\\something is valid in Windows.
Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64
Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64
Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
%COMMANDER_EXE% /i=D:\my.ini
Why not?
Overquoting is evil! 👎
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
I agree that %COMMANDER_INI_PATH% should NOT end with a backslash - it is inconsistant with %COMMANDER_PATH%
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.ghisler(Author) wrote: 2024-01-19, 07:58 UTC you can't use a backslash consistently when it's possible that the location is a drive root
Overquoting is evil! 👎
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
Finally this poster noticed it too...Fla$her wrote: 2024-01-19, 20:35 UTC And why can't? %COMMANDER_DRIVE% doesn't return "\". We can use %COMMANDER_DRIVE%\blabla. It's the same here.
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
I don't see this poster or anyone else noting this before. My question is posed differently...
Overquoting is evil! 👎
Re: [Tc11] Suggestion: COMMANDER_INI_PATH
Tc11.03RC2: Implemented. Perfect. Thanks.
Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH
But why?21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
%COMMANDER_INI_PATH% = C:\TC
%COMMANDER_INI_PATH%\file.ext = C:\TC\file.exe
%COMMANDER_INI_PATH% = D:\
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext
Overquoting is evil! 👎
Re: [Implemented in Tc11.03RC2] [Tc11] Suggestion: COMMANDER_INI_PATH
Oh, not perfect for working with.Fla$her wrote: 2024-01-23, 19:43 UTC%COMMANDER_INI_PATH% = D:\21.01.24 Fixed: Removed trailing backslash from environment variable %COMMANDER_INI_PATH% (except in root) (32/64)
%COMMANDER_INI_PATH%\file.ext = D:\\file.ext![]()
2ghisler(author)
It is true, has the root folder has really the name "letter:\" (other than all other folders). But in this case is "letter:" better for handling with the env var. Please change it.
Last edited by JOUBE on 2024-01-23, 19:54 UTC, edited 5 times in total.