solved [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 16001
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

solved [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *petermad »

If I have loaded a button bar file from a folder where I don't have write access (for example in a subfolder to "C:\Program Files"), and I change a button in the bar (by right clicking the button), then I get a dialog telling me that there is an error writing the file - and I am offered 3 options:
"Copy it to a directory in your profile"
"Grant yourself write rights (requires admin rights)"
"Cancel"
If I choose "Grant yourself write rights (requires admin rights)" then that button bar is made the default without warning. That is unexpected (and annoying).

If I change the default button bar back to what i was, and then load the button bar, that I now has write rights to, I can change it all I want without having it set as the default button bar - it is only the first time where the write rights are granted, that the problem occurs.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *ghisler(Author) »

This should be fixed in Total Commander 11.50 beta 1, please check it!
15.07.24 Fixed: When saving a button in a button bar failed and the user chose "Copy it to a directory in your profile", the new location was stored as main bar even if the bar wasn't the main (please note that the links to that bar need to be changed manually) (32/64)
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16001
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *petermad »

Confirmed fixed in TC 11.50b1.

But I think the text in history.txt should be changed to:
15.07.24 Fixed: When saving a button in a button bar failed and the user chose "Copy it to a directory in your profile" or "Grant yourself write rights (requires admin rights)", the new location was stored as main bar even if the bar wasn't the main (please note that the links to that bar need to be changed manually) (32/64)
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *ghisler(Author) »

I didn't check that second case, did you check whether it was fixed for that case too?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16001
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *petermad »

did you check whether it was fixed for that case too?
yes, it is fixed for that case too :-)
Actually "Grant yourself write rights (requires admin rights)" was the case I originally reported.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.03] Changing a button in a button bar can make the button bar permanent, when write access is restricted

Post by *ghisler(Author) »

Great, thanks!

Moderator message from: ghisler(Author) » 2024-10-10, 14:33 UTC

Moved to fixed bugs
Author of Total Commander
https://www.ghisler.com
Post Reply