solved [TC 11.50b1] Missing translation string.

[petermad]

There seem to be missing a translation string for "7ZIP" in the top of the 7Zip packer configuration dialog.

I would like to be able to translate the string so I can set that - and all other occurrences of "7zip" to "7-Zip" which is the correct name.

Currently TC uses "7ZIP", "7Zip" and "7zip" in the dialogs - a little consistency would be nice.

[ghisler(Author)]

I would prefer to not make it translatable. Maybe we can agree on a unified spelling? Which one would you suggest?
The reason why it's all uppercase there is because ZIP is also all uppercase.

[Hacker]

Christian,
"7-Zip" is used on https://www.7-zip.org/ .

HTH
Roman

[petermad]

I would also like "7-Zip" for the name of the packer.

But maybe 7ZIP is proper to use in the header of the group box, since all other group boxes for the packers (ZIP, ARJ, LHA, RAR, ACE and TAR) are in uppercase - and uppercase is also used for them all in the "Pack files" dialog.

But anywhere else I think 7-Zip is appropriate - that incluses the left side list in the Configuration dialog.

So no new string needed, but change these strings:

Code: Select all

6750="7Zip packer"
6751="&7ZIP packer:"
6752="Use &internal 7ZIP packer"
6753="&Prefer 7zip plugin if installed"
6754="7zip compression"

TO:

Code: Select all

6750="7-Zip packer"
6751="&7-Zip packer:"
6752="Use &internal 7-Zip packer"
6753="&Prefer 7-Zip plugin if installed"
6754="7-Zip compression"

[ghisler(Author)]

OK, I will use 7-Zip in most places, and 7-ZIP where the others are uppercase too, like in the Alt+F5 dialog.

[petermad]

OK, I will use 7-Zip in most places, and 7-ZIP where the others are uppercase too, like in the Alt+F5 dialog.

Is there enough space for 7-ZIP in the Alt+F5 dialog?

You could also consider using 7Z instead of 7ZIP in the Alt+F5 dialog and the top left of the configuration dialog - to go by extension rather than packer name in general.

But then LHA should probably be changed to LZH in the Alt+F5 dialog (in the configuration dialog both LHA and LZH is used already)

[ghisler(Author)]

Please let me know what you think about the changes in beta 2!

[petermad]

I am overall satisfied - but I think:

Code: Select all

6750="7Zip packer"

should be:

Code: Select all

6750="7-Zip packer"

BTW, why is this string not just incorporated in string 5102?

And then I think 7-ZIP in the Alt+F5 dialog is a little too much, I think that it should just be 7ZIP and then the first group box header in the 7-Zip Packer conf. dialog should also be 7ZIP.

see: https://tcmd.madsenworld.dk/7ZIPPacker.png

This way the radio button label in the Alt+F5 dialog always matches the group box header in the packer configuration dialogs , like it already does in the Packer conf. dialog: https://tcmd.madsenworld.dk/packerconf.png and the Zip Packer conf. dialog: https://tcmd.madsenworld.dk/ZIPPacker.png

___________________________

The changed string in TC 11.50b2:

Code: Select all

5246="S&et archive date to newest file date"

has a colliding hotkey with (untranslatable) string: "ACE (>= 2.04)".

I suggest changing string 5246 to:

Code: Select all

5246="Set archive date to &newest file date"

Talking about colliding hotkeys - here is my dglrange.txt file for TC 11.50b2: https://tcmd.madsenworld.dk/Dglrange1150b2.zip

__________________________

Now that we are at these packer dialogs - it seems to me that the strings:

Code: Select all

5221="&ZIP packer:"
5222="Configure ZIP packer..."

are not in use anymore - they were used in Windows Commander 3.x on the Packer tab to go to the Zip Packer tab https://tcmd.madsenworld.dk/wc303packerconf.png

Maybe those to string numbers could be used for:

Code: Select all

5221="Use internal un-RAR if p&ossible"
5222="Use internal un-ACE if possi&ble"

Currently those two strings are computed from string:

Code: Select all

5224="&Use internal un-ARJ if possible"

replacing ARJ with RAR and ACE and removing the hotkey. With two "new" strings 5221 and 5222 it will then be possible to add hotkeys to the items.

[white]

I think "7-Zip" should be used wherever possible.

And then I think 7-ZIP in the Alt+F5 dialog is a little too much, I think that it should just be 7ZIP and the the first group box header in the 7-Zip Packer conf. dialog should also be 7ZIP.

Does it not look good when using "7-Zip" in the Alt+F5 dialog? I know the others are in all caps. But the others are old and most of them stem from the DOS era. Perhaps it is good if 7-Zip stands out. It emphasizes that it is more modern.

This way the radio button label in the Alt+F5 dialog always matches the group box header in the packer configuration dialogs

I don't think that is necessary.

[ghisler(Author)]

I agree with white regarding the Alt+F5 dialog. What do other users think?

6750="7-Zip packer"

I agree too.

Regarding petermad's dlgrange.txt, I have one difference:
6751-6753,6756-6762,6767,5112 (the new 7-Zip page)
should be
5236-5239,6751-6767
because 5236-5239 from the "ZIP packer" page are used there too for the compression rate. I would also include all in range 6751-6767 in case a translator accidentally sets a hotkey to one of the strings without one.

[petermad]

2ghisler(Author)

should be
5236-5239,6751-6767

Agreed, but it should be:
5236-5239,6751-6767,5112

because you have to include the Apply button (5112)

[petermad]

As requested here: viewtopic.php?p=461658#p461658
I repeat this, even though it is about the help not about the language strings:

I noticed inconsistencies in the help page in spelling "7-Zip Packer" - I see "7-ZIP-Packer", "7-Zip-packer" and "7-Zip - Packer". I also see "7-Zip" referring to the Pack file dialog - that should be "7-ZIP" ( or preferably "7ZIP" )

[white]

In the Help pages there should be no dash between 7-Zip and packer. Same for the help page "Configuration - ZIP-Packer". There should be no dash between ZIP and packer.

[petermad]

There should be no dash between ZIP and packer.

I agree - that is why I listed the 3 places where there is a dash.

[ghisler(Author)]

I also see "7-Zip" referring to the Pack file dialog - that should be "7-ZIP" ( or preferably "7ZIP" )

Where?