[TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *white »

  1. Create a 256 bit hash for a file.
  2. Edit the file and change it a bit.
  3. Copy the hash to clipboard.
  4. Start menu option Files/Verify Checksums
  5. Verification fails of course.
  6. Don't close the window, but copy something else to the clipboard.
  7. Return to the open Verification window and choose another hash type at the bottom.
Now it says:
myfile.docx:

Errors: 0
OK: 0, not found: 0, read error: 0, wrong checksum: 0
It seems to me that when a hash is retrieved from clipboard, it should be stored. And not possibly use a different hash or no hash from the clipboard when another hash type is selected.

Also, It would be useful to give the user explicit feedback that a hash retrieved from clipboard is used, and possibly also to mention which hash.
For example by displaying this line in the main panel:
Verification by hash from clipboard.
Or:
Verification by hash from clipboard: a9b7744ca402ac17e137f500371ab1a5
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *ghisler(Author) »

I would prefer to show an error because the user may have wanted to get a different hash, e.g. from a web site, and try again.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *white »

ghisler(Author) wrote: 2024-11-01, 16:35 UTC I would prefer to show an error because the user may have wanted to get a different hash, e.g. from a web site, and try again.
First, it seems clear to me that when working with the clipboard, you should always retrieve the value from clipboard as soon as possible and store it immediately and not later on retrieve the value from clipboard again.

Second, it is very unlikely that the user may have wanted to get a different hash, e.g. from a website, and try again. It is much more likely that he wants to use the same value, but with a different hash type. That's the reason you added the option to be able select the hash type. Clipboard contents may change at any given time and considerable time may have passed since the user started verification process. Your view only makes sense if for example you would have a button called "Get new value form clipboard and try again". Besides that, following your line of thought, in order to try again with the same hash type and a different hash value from clipboard, people must copy a new value to clipboard and then change the hash type to different type and then change it back again.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *ghisler(Author) »

Second, it is very unlikely that the user may have wanted to get a different hash, e.g. from a website, and try again.
OK, after thinking about it for while I get to the same conclusion - the user may have already started a crc check for another file.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *ghisler(Author) »

This should be fixed in beta 5, please check!
03.11.24 Fixed: Verify checksums: Use same checksum for clipboard also during second pass (other checksum method), even if the clipboard content was changed in the meantime (32/64)
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b4] Verify Checksums: When hash from clipboard is used, it should be stored

Post by *white »

Tested OK using TC 11.50b5 32-bit and 64-bit.

Moderator message from: white » 2024-11-06, 18:14 UTC

Moved topic
» from TC11.x bug reports (English) to TC Fixed bugs
Post Reply