Inappropriate re-use of string 5183

[yong]

This may not be a bug, but it's been bothering me for quite some time, so I think
it's worthwhile to raise the issue here.

String 5183 is used twice in the Configuration dialog - page Edit/View to indicate
both the name and the hotkey of the external viewer. This string has a hotkey
which is particularly problematic for East Asian languages, because in these
languages the hotkey is not indicated within the string, but after
the string and surrounded by parentheses, like

Code: Select all

5183="外部查看程序(&X):"

Now that string 5183 is used twice in the configuration page, if we switch to
one of the East Asian languages (Chinese, Korean, etc), we have two strings
with the same hotkey, which is not quite desirable.

Another issue with this string is that it has a trailing colon, and strings 5181 and
5182 don't.

The best solution, I think, is to add a new string (without an inherent hotkey)
for the hotkeys.

[ghisler(Author)]

Thanks for your report. It's not a big problem, I will just remove the entire section in the form (&X) if present, and also the colon. It will be in beta 7 tomorrow.

[petermad]

Well in Danish the string is:

Code: Select all

5183="&Ekstern fremviser:"

In TC 11.50b6 and earlier the top string showed the hotkey and the bottom string had no hotkey: See. https://tcmd.madsenworld.dk/editviewtc1150b6.png - and that was fine.

Now, in TC 11.50b7 in the bottom string, the E is removed, and there is an underscore at k See: https://tcmd.madsenworld.dk/editviewtc1150b7.png Higly unacceptable.

[yong]

Well in Danish the string is:

Code: Select all

5183="&Ekstern fremviser:"

In TC 11.50b6 and earlier the top string showed the hotkey and the bottom string had no hotkey: See. https://tcmd.madsenworld.dk/editviewtc1150b6.png - and that was fine.

Now, in TC 11.50b7 in the bottom string, the E is removed, and there is an underscore at k See: https://tcmd.madsenworld.dk/editviewtc1150b7.png Higly unacceptable.

Maybe it's because the hotkey is set on the first letter. The same happens in Polish and Slovenian too, but it's fixed in other languages.

[ghisler(Author)]

You are right, I didn't consider this special case.

[ghisler(Author)]

This was fixed in beta 7, please check it!

19.11.24 Fixed: Removed hotkey in the form (&X) from Asian translations, and also the colon ":" from re-used string 5183 (32/64)

1. Open Configuration - Options - Language
2. Change language to "Simplified Chinese", but do NOT click OK!
3. Click "Apply"
4. Go two pages down
-> I n the section for the hotkeys (with the labels F3, Shift+F3 and Alt+F3), the third one should not have a hotkey in the form "(X):"
5. Go two pages up (language)
6. Change the language back to what it was before
7. Click OK

[yong]

Yes, it's fixed in beta 8.

Thank you, Mr Ghisler!

[ghisler(Author)]

Great, thanks for coming back to confirm!

Moderator message from: ghisler(Author) » 2024-11-28, 08:00 UTC

Moved to fixed bugs

[petermad]

Confirmed that

Code: Select all

 5183="&Ekstern fremviser:"

is now shown correctly in TC 11.50b8