[TC 11.50b8] ->.ico not working when filepath contains quotes

[Stiltzkin]

does not work:

Code: Select all

"C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
"%PROGRAMFILES(x86)%\Microsoft\Edge\Application\msedge.exe"

works:

Code: Select all

%PROGRAMFILES(x86)%\Microsoft\Edge\Application\msedge.exe
C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe

[ghisler(Author)]

Where is that defined? In the button bar?

[Stiltzkin]

in the "icon file:" textfield.

for example:

Code: Select all

TOTALCMD#BAR#DATA
msedge.exe
--enable-natural-scroll-default
"C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe"
Edge
"C:\Program Files (x86)\Microsoft\Edge\Application\"
-1
-1

[petermad]

It only works if the quotes in the "Icon file" field is removed:

Code: Select all

TOTALCMD#BAR#DATA
msedge.exe
--enable-natural-scroll-default
C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe
Edge
"C:\Program Files (x86)\Microsoft\Edge\Application\"
-1
-1

[AntonyD]

So the question is - WHY we can't use here the quotes - exactly ins that case - when they are deeply needed (((

And + btw - how to point out the 3 icon for example "buried" in this exe? In this case...
I thought that this should be like that: "C:\Program Files (x86)\Microsoft\Edge\Application\msedge.exe,3"
but obviously that this will not work, so HOW to do that?

[ghisler(Author)]

I don't understand, I tried using
"%PROGRAMFILES(x86)%\Microsoft\Edge\Application\msedge.exe"
with the double quotes in the "Icon file" field in the button bar, and the icons show up just fine.
What am I missing? I'm on Windoiws 11.

[white]

What am I missing? I'm on Windoiws 11.

It's about the "->.ico" button as mentioned in the thread's subject.

[Gral]

In other words: press "-> .ico" button - "Save as" window does not show up when path on "Icon file" field contains quotes.

[white]

BTW, in the given example, the specified Start path is "C:\Program Files (x86)\Microsoft\Edge\Application\" (including the quotes).
Quotes are not supported in the Start path. On my Windows 11 system, a start path enclosed within quotes always results in c:\ being used as start path.
And when you right-click the button, the entry "cd ..." is displayed without leading quote, but with trailing quote.

[Stiltzkin]

In other words: press "-> .ico" button - "Save as" window does not show up when path on "Icon file" field contains quotes.

yes, correct. the icon displays just fine in the buttonbar. it's just that the "->.ico"-button doesn't show the save as dialog.
it works without the quotes around the path.

windows 10, 22H2 x64

[Stiltzkin]

And when you right-click the button, the entry "cd ..." is displayed without leading quote, but with trailing quote.

same on win10. it ends with

Application\"

but if you click the entry the directory change is correct.

[ghisler(Author)]

It's about the "->.ico" button as mentioned in the thread's subject.

Ah, sorry, I didn't make that connection. Confirmed.

Quotes are not supported in the Start path.

Looks like ShellExecuteEx doesn't like quotes in the start path. I will not change this, it may break other people's configuration.

[petermad]

2ghisler(Author)

I will not change this, it may break other people's configuration.

But maybe you could make the -> .ico function disregard any quotes, that would not break backwards compatibility.

[ghisler(Author)]

But maybe you could make the -> .ico function disregard any quotes

Yes, I have already confirmed that above. What I won't change is the handling of the path field.

[petermad]

02.12.24 Fixed: Configure button bar/single button or configure internal command: New button "->.ico" didn't work when the icon name was surrounded by double quotes (32/64)

Confirmed fixed in TC 11.50rc1