solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *petermad »

If I use cm_packFiles with the parameter /C0 encryption is supposed to be turned off, but it has the same effect as using /C1 or /C

Also - cm_packFiles with parameters cannot be used inside a zip file - I had hoped I could have used:

Code: Select all

cm_GoToDir,cm_SelectAllBoth,cm_packFiles /C0GP="password"
to automatically repack encrypted zip files removing the encryption.

I don't know if is by design that cm_commands with parameters cannot be used inside archives or it is just a forgotten implementation
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
massor
Junior Member
Junior Member
Posts: 26
Joined: 2022-05-01, 18:30 UTC

Re: [TC 11.05b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *massor »

Does exist this version "TC 11.05b2"?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *ghisler(Author) »

Sorry, The /C parameter is described incorrectly.
/C=0 means ZIP enryption, 1=AES128, 2=AES192, 3=AES256, -1=default method
You cannot pack without enryption when providing a password, and you cannot re-pack files with cm_PackFiles and a parameter.
I will update the help.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *petermad »

Confirmed that the help for C in cm_PackFiles is changed to:
Help wrote:C: Encryption method: 0=old ZIP enryption, 1=AES128, 2=AES192, 3=AES256, -1=default method last chosen by the user
and
Help German wrote:C: Verschlüsselungsmethode: 0=alte ZIP-Methode, 1=AES128, 2=AES192, 3=AES256, -1=letzte vom Benutzer gewählte Methode
in TC 11.50b3 :-)

Moderator message from: petermad » 2024-10-23, 20:43 UTC

Moved to "TC fixed bugs" from "TC11.x bug reports (English)"
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *white »

Shouldn't the text "Each of the checkbox options takes an optional parameter 1 or 0." in the help be changed as well? For example like this:
[Help - Dialog box: Choose command] wrote:cm_PackFiles
All the options shown in the dialog box can be passed as parameters (starting with a slash). Each of the checkbox options takes an optional parameter 1 or 0.
  ⬇️
cm_PackFiles
All the options shown in the dialog box can be passed as parameters (starting with a slash). Each of the checkbox options takes an optional parameter 1 or 0 (except for the encryption option).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *ghisler(Author) »

I don't think that this is necessary:
C: Encryption method
isn't a checkbox option, just like
P="password"
isn't a checkbox option either. The checkbox option is "Encrypt", and method and password are set in a separate dialog box.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *white »

ghisler(Author) wrote: 2024-12-23, 10:31 UTC I don't think that this is necessary:
C: Encryption method
isn't a checkbox option...
OK, then shouldn't it be:
cm_PackFiles
All the options shown in the dialog box (except for Encrypt) can be passed as parameters (starting with a slash). Each of the checkbox options takes an optional parameter 1 or 0.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *ghisler(Author) »

Not really, you can use the encrypt option indirectly by setting a password and the method.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *white »

ghisler(Author) wrote: 2024-12-23, 11:08 UTC Not really, you can use the encrypt option indirectly by setting a password and the method.
Again, that would mean the text "Each of the checkbox options takes an optional parameter 1 or 0." is wrong. You are using circular reasoning.
Turning on the Encrypt option can be achieved by specifying an encrypt method, turning off the Encrypt option involves specifying a target with the T option (and not specifying an encryption method with the C option).
petermad wrote: 2024-10-23, 20:41 UTC
Help wrote:C: Encryption method: 0=old ZIP enryption, 1=AES128, 2=AES192, 3=AES256, -1=default method last chosen by the user
What does "-1=default method last chosen by the user" mean exactly?
Does it mean:
-1 or no parameter=use last used method
Or something else?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *ghisler(Author) »

No, it means the method the user has chosen when last packing with encryption manually. It's stored under section [Packer] as ZipAES.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *white »

ghisler(Author) wrote: 2024-12-24, 08:05 UTC No, it means the method the user has chosen when last packing with encryption manually. It's stored under section [Packer] as ZipAES.
So you with the text "default method last chosen by the user", you mean the default method which is the method last chosen by the user? Isn't it clearer to leave out the word "default"?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50383
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *ghisler(Author) »

No, the default method for packing with encryption is the one last chosen by the user.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5743
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: solved [TC 11.50b2] cm_packFiles /C0 does not turn encryption off as expected

Post by *white »

ghisler(Author) wrote: 2024-12-24, 09:31 UTC No, the default method for packing with encryption is the one last chosen by the user.
So you want to convey both things and merged them into one line. I think it's clearer to explicitly describe both things. Alternatives:
"default method (method last chosen by the user)"
"default method (user's last selection)"
Post Reply