When using dark mode and searching for duplicates: no dashed lines in search results panel

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

Enable dark mode and search for duplicate files.
There are no dashed lines in the search results panel of the Search dialog to group the duplicates together.

I have a hard time believing this isn't discussed before, but I cannot find any mention of this.
Please confirm the issue and whether it has already been mentioned somewhere.
User avatar
tuska
Power Member
Power Member
Posts: 4046
Joined: 2007-05-21, 12:17 UTC

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *tuska »

Hi,
I can confirm the issue but cannot find any discussion of it.

TC_clean_11.50RC3_x64_&_x86.ini | Test folder: C:\Everything\
Menu "Commands" > Search in separate Process... Alt+Shift+F7, Search... Alt+F7
Tab "Advanced" > ☑️ Find duplicate files > ☑️ same name > ☑️ same size

Code: Select all

Dark mode		Dashed lines
-------------------------------------------
Search results		NO		<==
"Feed to Listbox" 	Yes 

Normal mode		Dashed lines
-------------------------------------------
Search results		Yes
"Feed to Listbox"	Yes

Windows 11 Pro (x64) Version 24H2 (OS Build 26100.2605) - 2024-12-10
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6950
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *Horst.Epp »

Confirmed
In Dark mode, the dashed lines are only displayed after "Feed to listbox"
Windows 11 Home, Version 24H2 (OS Build 26100.3915)
TC 11.51 x64 / x86
Everything 1.5.0.1391a (x64), Everything Toolbar 1.5.2.0, Listary Pro 6.3.2.88
QAP 11.6.4.2.1 x64
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *petermad »

Confirmed also under Windows 7, both 32bit a dn 64bit TC.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

Since no one reported that this has already been discussed, I'm moving this thread to the bug reports forum.

Moderator message from: white » 2024-12-20, 23:28 UTC

Moved topic
» from Total Commander (English) to TC11.x bug reports (English)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *ghisler(Author) »

Confirmed, thanks.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *ghisler(Author) »

This should be fixed now in RC4, please test it!
21.12.24 Fixed: Find files, search for duplicate files: Separator lines between groups were not visible in dark mode (32/64)
I also found another bug related to duplicate file search while testing this, please test this too:
23.12.24 Fixed: Find files, search for duplicate files, close dialog, re-open dialog -> duplicate search results were lost (32/64)
Author of Total Commander
https://www.ghisler.com
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6950
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *Horst.Epp »

ghisler(Author) wrote: 2024-12-24, 10:51 UTC This should be fixed now in RC4, please test it!
21.12.24 Fixed: Find files, search for duplicate files: Separator lines between groups were not visible in dark mode (32/64)
I also found another bug related to duplicate file search while testing this, please test this too:
23.12.24 Fixed: Find files, search for duplicate files, close dialog, re-open dialog -> duplicate search results were lost (32/64)
The Separator lines are fixed.

The 2nd point is only ok, if I close the dialog with Cancel.
Windows 11 Home, Version 24H2 (OS Build 26100.3915)
TC 11.51 x64 / x86
Everything 1.5.0.1391a (x64), Everything Toolbar 1.5.2.0, Listary Pro 6.3.2.88
QAP 11.6.4.2.1 x64
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *petermad »

Confirmed that the missing dashed lines are fixed in TC 11.50RC4 :-)
The 2nd point is only ok, if I close the dialog with Cancel.
Or closing by pressing Escape - but that is not unique to Search for duplicates. Closing the dialog at the x in the title bar, or by pressing Alt+F4 also clears the last search result for ordinary searches. But maybe this is a feature?
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

petermad wrote: 2024-12-24, 12:54 UTC Confirmed that the missing dashed lines are fixed in TC 11.50RC4 :-)
The 2nd point is only ok, if I close the dialog with Cancel.
Or closing by pressing Escape - but that is not unique to Search for duplicates. Closing the dialog at the x in the title bar, or by pressing Alt+F4 also clears the last search result for ordinary searches. But maybe this is a feature?
Confirmed by me as well.
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *petermad »

From here: https://ghisler.ch/board/viewtopic.php?p=465987#p465987 it appears that it is by design that closing the dialog at the x in the title bar, or by pressing Alt+F4 clears the last search
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

petermad wrote: 2024-12-24, 13:19 UTC From here: https://ghisler.ch/board/viewtopic.php?p=465987#p465987 it appears that it is by design that closing the dialog at the x in the title bar, or by pressing Alt+F4 clears the last search
I think there are probably more users who are confused by this inconsistent behavior than users who want this.
sa16
Senior Member
Senior Member
Posts: 324
Joined: 2021-09-10, 07:15 UTC

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *sa16 »

white wrote:more users who are confused by this inconsistent behavior
They can set SearchKeepLast=0.
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *white »

sa16 wrote: 2024-12-25, 07:01 UTC
white wrote:more users who are confused by this inconsistent behavior
They can set SearchKeepLast=0.
Don't you mean the other group of people?

Wouldn't it be better that it works consistently either way. Always remember the last results no matter how you close the window, or never remember last results. If you want to give the user both options, wouldn't it be better to implement for example Shift+close to choose the alternative?
sa16
Senior Member
Senior Member
Posts: 324
Joined: 2021-09-10, 07:15 UTC

Re: When using dark mode and searching for duplicates: no dashed lines in search results panel

Post by *sa16 »

white wrote:Shift+close to choose the alternative?
It is not good that we would have to change the behavior that has existed for 14 years. But there would be an analogy with F8(Del) and Shift+F8(Del) and the UseTrash option...
Post Reply