Menus and other things that don't look right

Sob · Post by *Sob » 2011-10-03, 23:38 UTC

I'm happy to help. ;) I don't have access to all different Windows versions right now, but I think the following sample is quite representative:

http://web.hisoftware.cz/sob/img/windows-menu-style.png

Flat menu column = result from SystemParametersInfo(SPI_GETFLATMENU), XP+ only

Post by *ghisler(Author) » 2011-10-05, 10:13 UTC

Thanks, that helped a lot! It seems that TC currently always uses the "flat menu" form. I will use SystemParametersInfo on XP and newer to check that option, and draw the non-flat menu otherwise.

Post by *ghisler(Author) » 2011-10-07, 13:05 UTC

Please check with beta 4, and report if any don't look right! Note that the menu bar background on XP with themes is still using the default XP menu bar look.

Sob · Post by *Sob » 2011-10-07, 17:57 UTC

I checked it where I could, it didn't break anything and looks much better with Classic theme. There's only one small difference left, possible to miss if you're not looking for it and it's the text position when item is selected. Usually the selected text is moved one pixel right and one pixel down to give the impression of pressed button (for non-flat menus only).

Comparison: http://web.hisoftware.cz/sob/img/tc80b4x64-menu.gif

No major trouble of course, the frame vs. background made the most important difference, but it would make it 100%. :)

sekular · Post by *sekular » 2011-10-07, 19:36 UTC

Beta 4 has fixed the main menu cutting off the end of texts for me and I use the uxtheme patch and custom themes.

Post by *ghisler(Author) » 2011-10-09, 14:10 UTC

Thanks for confirming the fix! I will check about the moved text, are you sure that this is done in other programs? Currently I have themes on, and here it does NOT move.

Sob · Post by *Sob » 2011-10-09, 14:35 UTC

It's correct. Text is _not_ moved with themes on nor with flatmenus on. It applies _only_ to Classic (win9x) style (so _only_ the case when you draw 3D sunken border).

Post by *ghisler(Author) » 2011-10-10, 13:37 UTC

OK, I will try to add it. Does it happen in Lister too? In this case, the menu is drawn by Lazarus, not TC itself.

Sob · Post by *Sob » 2011-10-10, 16:26 UTC

Only partially, text is moved one pixel right only, not down. But it's bug in Lazarus, all system-drawn menus have it as seen in animgif above.

Post by *ghisler(Author) » 2011-10-11, 16:28 UTC

I see - so I will fix it just in the main window for now.

Sob · Post by *Sob » 2011-10-14, 15:32 UTC

Main window menubar is now perfect in beta 5, thanks. No more complaints from me. :)

Post by *ghisler(Author) » 2011-10-14, 15:53 UTC

The only remaining problem is Windows XP with themes on, ther I will have to draw the toolbar theme as background somehow.

Sob · Post by *Sob » 2011-10-14, 17:00 UTC

You did that in beta 1, so you could probably conditionally (NT 5.x, themes on) use that code...

And I found one more thing. This is how all betas look under XP64:

http://web.hisoftware.cz/sob/img/tc80x64-menu-winxp.png

With themes disabled, the color of items and empty space is different (except in beta 2 where menubar was drawn by Lazarus). It's small difference (rbg 224, 226, 235 / rgb 224, 223, 227), but it's there. It was previously discussed in Themes in menu bar (Beta 2). Beta 5 brought this behaviour also for themes enabled.

Post by *ghisler(Author) » 2011-10-16, 14:21 UTC

I could find a way now to draw the XP background theme. I will add it to the next beta.

Flint · Post by *Flint » 2011-10-21, 12:12 UTC

Tested in XP x64, Luna theme: works excellent!