Possible buffer overflow in BTM / FTP download from list

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
Mirco
Junior Member
Junior Member
Posts: 4
Joined: 2007-05-05, 03:28 UTC

Possible buffer overflow in BTM / FTP download from list

Post by *Mirco »

Possible buffer overflow in BTM / FTP download from list. Bug?

I tried to download a series of data files from the Australian Bureau of Statistics website using "FTP download from list..." and suddenly TC crashed without any noise and/or error message. :(

I have tested versions 6.56 and 7.0 and I discovered that the problem seems to be connected with the length of the URL.
  1. URL length 0-303 chars: OK (at least regarding the download)
  2. URL length 304-315: TC displays an error message:
    • TC6.56 - Fatal error in ftp thread, aborting!
    • TC7.0 - Fatal error in BTM thread, aborting!
  3. URL length 316+: TC crashes (dies) without any error message
It seems that there is 259 (260) character limit for downloaded URLs. But this applies only to URLs entered manually - using the "+" button of the Background Transfer Manager (Menu | Commands | BTM). This limit does not apply when the downloads are invoked via "FTP download from list" and it looks like somethings gets overwritten by the URL string. :(

Unlike NTFS file names, URLs can be much longer than 259 characters (I have found some having 600-700 chars), so I think this limit should not apply to URLs. I could use an external download manager, but I would still prefer TC.

P.S. :evil: argghhhh, I'm not allowed to post a sample link, even that I meet the following criteria:
In order to try to prevent spammers, we do not allow our users to post URLs in any form until they have posted at least 1 legitimate posts and have been with us for more than 3 days.
Mirco
Junior Member
Junior Member
Posts: 4
Joined: 2007-05-05, 03:28 UTC

Post by *Mirco »

Here is a :arrow: sample URL (containing 361 chars) to reproduce the error (right-click, copy the link address to clipboard and save to a file of your choice, then Menu | Net | FTP Download from list...)
User avatar
Clo
Moderator
Moderator
Posts: 5731
Joined: 2003-12-02, 19:01 UTC
Location: Bordeaux, France
Contact:

TC killed

Post by *Clo »

2Mirco

:) Hello !

• I tested in 7.0xx, I can confirm using your URL as a text-list : TC is killed immediately, not any message.
- TC is not even in a background thread, I checked too.

- I pasted this URL in the address-bar of Opera 9.21 browser, it works.

But it shows only a page, not a transfer¦download to perform… :?:

:mrgreen: Kind regards,
Claude
Clo
#31505 Traducteur Français de TC French translator Aide en Français Tutoriels Français English Tutorials
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I can confirm that. The BTM URL length is limited when the paths are added to the list, not later. I will add an additional check.
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3501
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

Fixed in 7.01.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
Post Reply