Installer bug...or maybe just a quirk

[Innuendo]

In my mind this is a bug, but it's at least a quirk I could do without in the installer.

The scenario is that I only speak English so I install Total Commander with only the English language files. When running the installer for a later version when asked if I want to do an Update install or a Normal install I have been choosing Update.

Now in my mind the Update install option should just update the existing install based on what's already on the hard drive. Instead all the language files are installed each time meaning I have to go in after the installer finishes and delete the language files I never wanted.

I think the solution would be to either just update the language files already installed on the system or present the "Do you want to install all the languages" question again that one is asked when doing a clean install.

This post should be a testament to how awesome I think Total Commander is if the installing of unwanted language files is the only thing I can find to complain about.

[Hacker]

Direct upgrade install passes also all other language files

Roman

[Innuendo]

Thank you for pointing that out to me, Hacker. It would not have occurred to me to look over there for discussion of this issue.

[ghisler(Author)]

The installer installs all languages if it finds at least two lng files in the language dir. Here is the code I'm using:

Code: Select all

void SetLangCopyDefault()
{
    char buf[260];
    HANDLE findhandle;
    WIN32_FIND_DATA s;
    
    strcpy(buf,thedir);
    strcatbackslash(buf);
    strlcat(buf,"language\\*.lng",sizeof(buf)-1);
    findhandle=FindFirstFile(buf,&s);
    if (findhandle!=INVALID_HANDLE_VALUE) {
        // If we have at least two lng files, install all
        if (FindNextFile(findhandle,&s)) {
           instlang[0]=0;
        }
        FindClose(findhandle);
    }
}

instlang is otherwise set to e.g. wcmd_eng, wcmd_deu or other selected language to install only that language. I don't currently see why all languages would be installed in your case...

[skuzi]

Confirm.
Had TC 7.5 beta 3 with english only language.
Made update to beta 4, all other language files appeared.
I don't think it's problem, it's just annoying a little bit.

[ghisler(Author)]

I think that I found a good solution now, installing only languages where either a lng or mnu file with the same name is already there.

[karlchen]

Hello, Christian.

Quoting my own message sent inside the beta forum, I will publically confirm:

Installing the languages works as designed and intended using the setup programme provided by T.C. 7.50 PB5.

Starting situation: "language" folder a little messed up in order to cover all your cases plus the one that all available old language files are present:

Code: Select all

WCMD_DAN.LNG => (1) Danish should be completed and updated
WCMD_DEU.INC
WCMD_DEU.LNG
WCMD_DEU.MNU => (5) German should be updated
WCMD_ENG.MNU => (2) mean: English should be updated
WCMD_ESP.MNU => (2) Spanish should be completed and updated
WCMD_FRA.INC => (3) French should not be touched
WCMD_SK.LNG => (1) Slovak should be completed and updated
=> (4) no language should be added

Executed update installation. This is the result: (1)

Code: Select all

WCMD_DAN.INC	14.027	11.06.2009 07:50	-a--
WCMD_DAN.LNG	67.125	11.06.2009 07:50	-a--
WCMD_DAN.MNU	5.661	11.06.2009 07:50	-a--
WCMD_DEU.INC	14.525	11.06.2009 07:50	-a--
WCMD_DEU.LNG	72.714	11.06.2009 07:50	-a--
WCMD_DEU.MNU	5.593	11.06.2009 07:50	-a--
WCMD_ENG.MNU	5.194	11.06.2009 07:50	-a--
WCMD_ESP.INC	14.252	11.06.2009 07:50	-a--
WCMD_ESP.LNG	68.867	11.06.2009 07:50	-a--
WCMD_ESP.MNU	6.268	11.06.2009 07:50	-a--
WCMD_FRA.INC	16.713	28.05.2009 07:50	-a--
WCMD_SK.LNG	69.209	11.06.2009 07:50	-a--
WCMD_SK.MNU	5.668	11.06.2009 07:50	-a--

1. There is just the lng file -> lng, mnu and inc (if available) for that language are installed

Correct. Danish has been completed and all 3 files have been installed. The same is true for Slovak. Missing files has been added. 2 files up-to-date.

2. There is just the mnu file -> same as 1

Correct. English has been updated, 1 file. Spanish has been completed and updated, 3 files.

3. There is just the inc file -> language not reinstalled

Correct. French has not been touched. The old INC file is still present, but French MNU and LNG have not been installed.

4. There is no file at all for that language -> language not reinstalled

Correct. No languages have been added.

5. case: Correct. German has been correctly updated. All files had been present before. Old versions of course.

Summary
Yes, installing the languages works as designed and intended.

Testing environments:
+ Windows Vista Home Premium, 32bit
+ Windows XP Prof SP2, 32bit
+ Total Commander 7.50 pb5 (updating pb4)

Kind regards,
Karl
--
(1)
The installation has been repeated using the final PB5 setup. This is why the file dates have changed compared to the original message posted in the beta forum.

[ghisler(Author)]

Thanks very much! Can anyone else confirm the correction, please? I need the confirmation of either the thread starter or 2 other testers (from which I have one now).

[HolgerK]

02.06.09 Added: Installer, update mode: Only install languages where the lng or mnu file was already installed

Confirmed!
Tested with several combinations of one to three files types lng, mnu, inc.
Only the single inc file (as expected) wasn't updated.

TC7.50pb5, Vista ultimate (x86)

Regards
Holger

[ghisler(Author)]

Thanks!