internal zip is broken or creates bad files

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
seb
Member
Member
Posts: 131
Joined: 2003-03-04, 07:41 UTC

internal zip is broken or creates bad files

Post by *seb »

http://cd.textfiles.com/cream/cream03/games/dotso.zip

this is a zip file including a comment

now delete all files from there

the resulting empty zip (including the comment) cannot be entered with total commander

im using wine, perhaps some windows users can check this behaviour :-)))
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I can confirm the behaviour under Windows XP SP3.

The file must be packed with some exotic zip-packer. I can delete everything down to 1 file, but not to 0 files.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
seb
Member
Member
Posts: 131
Joined: 2003-03-04, 07:41 UTC

Post by *seb »

i just tested that with a self-created file.
i was using Info-ZIP - Zip 3.0 (July 5th 2008).
same problem...

please test with a self created file
create a new archive.
add one file to the archive
add comment to the archive (not the file inside!)

i doubt its a problem of the format, since i guess TC rewrites that when deleting (all) files from the archive.
User avatar
petermad
Power Member
Power Member
Posts: 16032
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I just tried it using TC's own zip packer - packed a file, gave the zip file a comment and deleted the file from the zip archive, no problems. I can enter the empty zip file without any problems.

I tried both with files.bbs and with descript.ion as comment files in TC. But maybe you are talking about a comment that your zip-packer provides???
i doubt its a problem of the format, since i guess TC rewrites that when deleting (all) files from the archive.
Maybe TC doesn't rewrite all of the file. If I make such and empty file with TC - it is 22 bytes, the file of yours (dotso.zip) is 144 bytes when emptied - and it contains a hidden comment (not a file):
From Cream of the Crop 3 cd rom 205-824-2552 Description: Connect the Dots With New Twist to Classic Game. Ega/Vga
- TC apparently doesn't support that for empty files.

If embeded comments is a zip standard, then there is a bug in TC - if it propritary, then you can't blame for not supporting it.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
seb
Member
Member
Posts: 131
Joined: 2003-03-04, 07:41 UTC

Post by *seb »

http://www.pkware.com/documents/casestudies/APPNOTE.TXT

yeah the comment is from the standard and according to the changelog its not a newer feature

anyway TC handles these comments correct if you delete some files from the archives

it just throws up if you delete all files from the archive :-)
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Indeed Total Commander does NOT support empty archives with a comment, only empty archives without a comment, or non-empty archives with a comment. Currently there are no plans to support empty archives with a comment.
Author of Total Commander
https://www.ghisler.com
seb
Member
Member
Posts: 131
Joined: 2003-03-04, 07:41 UTC

Post by *seb »

just stumbled over this "problem" again.
i know it's not a common case but perhaps it's really not such a hard thing to "fix" / add support for?! :-)
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6975
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp »

seb wrote:just stumbled over this "problem" again.
i know it's not a common case but perhaps it's really not such a hard thing to "fix" / add support for?! :-)
This may be done if there are no more other errors or problems at all in TC.
Thats wasting time for useless cases.
Post Reply