[32/64] TC doesn't extend selection if selected file clicked

[MVV]

Strange, I didn't noticed it, however this bug exists in TC 7.56a too.

1. Open folder with at least 10 files for test.
2. Select files #4-#7.
3. Focus file #2.
4. Press Shift and click file #5.

IMHO it is expected that files #2 and #3 become selected since you select them via Shift+Click, but TC just moves focus to file #5. If I click e.g. file #9, all works as expected - files #2-#9 become selected.


Also following sequence is quite strange:

2. Select files #3, #4, #7, #8.
3. Focus file #3.
4. Press Shift and click file #9.

IMHO entire sequence #3-#9 should become selected (and this is so in TC 7.56a). But it is not so in TC8x32 and TC8x64: files #5, #6 remain unselected. However, if I focus file #2 in step 3, all works as expected - files #2-#9 become selected.

Both may be reproduced with clean INI.

Win7x64ProSP1

[Flint]

Confirm all the findings.

[ghisler(Author)]

Strange, I will check it. Maybe it's because the shift-clicked file is already selected.

[MVV]

Not fixed in Beta2.

[ghisler(Author)]

Sorry, I didn't change this behaviour because I'm not sure whether it's intentional or not.

[MVV]

I think TC should do something on Shift+Click. Currently TC does nothing in such case - it neither selects band nor deselects.

IMHO only first item state should be important here. If I have first item selected and use Shift+Click, I wanna to deselect band, if first item is deselected, I wanna to select band, there is no case when I want just to move focus when Shift is pressed.

[ghisler(Author)]

Sorry, I just didn't have the time to look into this in detail yet. I will put it on my to do list for beta 3.

[ghisler(Author)]

I have changed this now, please check whether the change as you expect it.

[MVV]

Great, it works like expected when non-selected file is focused and I click focused one!!

Unfortunately there is a strange thing when I focus selected file and then Shift+click another selected one (from another group, e.g. #3-#4 are selected and #8-#9 are selected too).

When I focus file #8 and Shift+click file #4, all works fine (TC merges groups). But when I focus file #4 and Shift+click file #8, TC just moves focus, or only file #7 becomes selected. Files #5-#6 should be selected too!

Also there is a bug: if I focus file #3 and Shift+click file #4, TC selects files #5-#7!!! Exact steps: deselect all, select #3, #4, #8, #9, focus #3 and Shift+click #4.

[ghisler(Author)]

When I focus file #8 and Shift+click file #4, all works fine (TC merges groups). But when I focus file #4 and Shift+click file #8, TC just moves focus, or only file #7 becomes selected. Files #5-#6 should be selected too!

NOT confirmed with beta 3! I tried with both left and right mouse button selection mode. Can you give me more details, please?

When I focus file #8 and Shift+click file #4, all works fine (TC merges groups). But when I focus file #4 and Shift+click file #8, TC just moves focus, or only file #7 becomes selected. Files #5-#6 should be selected too!

Not confirmed either.

[MVV]

I can reproduce it with clean ini, both TC8b3x32 and TC8b3x64. Create 9 files in a folder with names 1, 2, 3, ..., 9 (for easy testing). I will mark error behaviour with red text color. Steps:

1. Select files 3, 4, 8, 9 in this order using mouse right clicks.
2. Focus file 8.
3. Hold Shift and click file 4. Files 5, 6, 7 are now selected - OK.

1. Select files 3, 4, 8, 9 in this order using mouse right click.
2. Focus file 4.
3. Hold Shift and click file 8. Files 5, 6, 7 are still unselected!

1. Select files 3, 4, 8, 9 in this order using mouse right click.
2. Focus file 4.
3. Hold Shift and click file 3. Files 5, 6, 7 are now selected!

It seems that TC somehow remembers some previous focus position and uses it instead of actual one that was exactly before Shift+click.

[petermad]

I can confirm MVV's observation as described.

It is not much better in TC 7.56a - here nothing is selected in any of MVV's 3 tests ! But if I select 3, 4, 8 and 9, focus 4 and Shift+click on 5 then 5, 6 and 7 are selected (as in TC 8.0b3).

[ghisler(Author)]

2MVV
Thanks, that helped. The selection does work, but the positioning of the start position when clicking on an already selected item WITHOUT shift doesn't. I will fix that in beta 4.

[MVV]

Thanks, it's fixed completely in 8b4!

[ghisler(Author)]

Ah, finally, thanks for checking! Please let me know if you find any other situation where it doesn't work correctly.