[8.0ß2-x64] Hotkeys in SyncDirs context menu right-aligned

Flint · Post by *Flint » 2011-09-28, 08:26 UTC

Open SyncDirs, perform comparison, then right-click on any file to display the context menu. All the hotkeys in this menu are aligned by the right margin, not by the left one like e.g. in main menu.

Sob · Post by *Sob » 2011-09-28, 13:47 UTC

Explanation is simple. Submenus in main window are drawn by TC and have hotkeys always aligned to left. Compared to native menus, it's correct for Classic theme, incorrect for modern Vista+ themes and I'm not exactly sure about XP themes. Most other (if not all) menus are drawn by Lazarus and have hotkeys always aligned to right. And it's not the only thing where autors lacked sense for details.

Flint · Post by *Flint » 2011-09-28, 14:22 UTC

Sob wrote:Compared to native menus, it's correct for Classic theme, incorrect for modern Vista+ themes and I'm not exactly sure about XP themes.

In XP native menus are left-aligned (checked in Paint and Notepad).

Post by *petermad » 2011-09-28, 16:37 UTC

I don't see any hotkeys at all in the sync right-click menu, unless I use the Classic theme with the x64 version.

By hotkeys I mean the CTRL+D, CTRL+M, CTRL+L etc. hotkeys, not the underlined hotkeys S, R, l etc. which are still visible.

With the x86 version under Win 7 the hotkeys are right aligned.
With the x86 version under Win XP the hotkeys are left aligned.

Flint · Post by *Flint » 2011-09-28, 19:15 UTC

petermad wrote:By hotkeys I mean the CTRL+D, CTRL+M, CTRL+L etc. hotkeys

Yes, that's what I'm talking about too.

Post by *petermad » 2011-09-28, 21:15 UTC

Just to make it clear:

TC 8.0b2 x64 under Win 7 (Luna Silver theme): http://madsenworld.dk/tcmd/synccontextx64.png

TC 8.0b2 x86 under Win 7 (Luna Silver theme): http://madsenworld.dk/tcmd/synccontextx86.png

TC 8.0b2 x86 under Win XP (Luna Silver theme): http://madsenworld.dk/tcmd/synccontextx86xp.png

Post by *ghisler(Author) » 2011-09-30, 10:27 UTC

OK, in beta 3 the main menu hotkeys will now also be right-aligned when using Vista or 7 with themes.

Flint · Post by *Flint » 2011-09-30, 10:35 UTC

ghisler(Author)
What about pre-Vista systems?

MVV · Post by *MVV » 2011-09-30, 11:26 UTC

ghisler(Author) wrote:OK, in beta 3 the main menu hotkeys will now also be right-aligned when using Vista or 7 with themes.

Sorry but there are no shortcuts at all in B3 under Windows 7 with Aero theme. If I return to classic theme, I see shortcuts, but they are aligned to right and there is no tabulator between item captions and shortcuts at all.

Post by *ghisler(Author) » 2011-09-30, 11:53 UTC

Not confirmed. Try with a fresh ini please.

Post by *petermad » 2011-09-30, 23:07 UTC

Sorry but there are no shortcuts at all in B3 under Windows 7 with Aero theme.

Same here - it still looks like http://madsenworld.dk/tcmd/synccontextx64.png in x64 version - no CTRL+D, CTRL+M, CTRL+L etc. hotkeys in the right side.

Also the 32bit version under Win 7 x64 still looks like http://madsenworld.dk/tcmd/synccontextx86.png - with the hotkeys left-aligned - in contrast to http://madsenworld.dk/tcmd/synccontextx86xp.png when run under win XP x86

Did try with fresh ini file

Post by *ghisler(Author) » 2011-10-02, 15:29 UTC

Strange, it works fine here.

I will have to do more tests.

Sob · Post by *Sob » 2011-10-02, 20:50 UTC

Missing shortcuts in context menu in Synchronize directories

- Only in TC64
- Not missing on XP64 (both themes on and off)
- Not missing on Win7 with Classic theme (or themes off, which is basically the same thing)
- Missing on Win7 with any other theme (tested with clean ini and even clean Windows)

Shortcut alignment in menus

As I see it:

TC64:

main window dropdown menus (drawn by TC)
- Classic theme - left, correct
- XP theme - left, correct
- Vista+ theme - right, correct
tab context menu (looks like native menu)
- Classic theme - left, correct
- XP theme - left, correct
- Vista+ theme - right, correct
synchronize dirs context menu (drawn by Lazarus)
- Classic theme - right, wrong (*1)
- XP theme - right, wrong (*1)
- Vista+ theme - missing, see problem above, otherwise it would be right, correct

TC32:

main window dropdown menus (drawn by TC)
- Classic theme - left, correct
- XP theme - left, correct
- Vista+ theme - right, correct
tab context menu
- Classic theme - left, correct
- XP theme - left, correct
- Vista+ theme - right, correct
synchronize dirs context menu
- Classic theme - left, correct
- XP theme - left, correct
- Vista+ theme - right, correct

(*1) Lazarus has currently no support for left-aligned shortcuts. I have patch for that together with few other changes to make the menus look as much as native ones as possible, which I'd like to get accepted for Lazarus one day. But currently it's still work in progress, although the only deficiency I'm aware of is not pixel-perfect menu item dimensions. But I don't know how much is author willing to change LCL sources for TC, if this wouldn't be too much code.

http://web.hisoftware.cz/sob/download/lcl-win32-menu-classic-more-native-look-wip1.png
http://web.hisoftware.cz/sob/download/lcl-win32-menu-classic-more-native-look-wip1.patch

Post by *ghisler(Author) » 2011-10-03, 21:17 UTC

Thanks for your tests, I could reproduce it now! It is indeed a Vista/7 theme problem.

Flint · Post by *Flint » 2011-10-07, 12:50 UTC

Missing hotkeys in SyncDirs context menu in Vista/7 are fixed in 8.0β4 (tested in Win2008R2, Win7 Basic theme).