[TC 8.0b5 x64] high memory usage when deleting files

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

esque
Junior Member
Junior Member
Posts: 14
Joined: 2009-09-11, 11:17 UTC

[TC 8.0b5 x64] high memory usage when deleting files

Post by *esque »

I'm not quite sure if this is a bug, but that's for you to decide.

I used TC 8.0b5 x64 to delete about 50 GB of files (lots of directories, thousands of files). As this took quite a time I put the delete action in the background and kept on working.

After a while the system (Phenom x4, 3,2 GHz, 8 GB RAM, Win 7 Home Prem. x64) became sluggish, later almost unusable.
When I tried to find the reason I saw that TC used almost 7 GB of RAM, leaving next to nothing for other programs.

When i killed TC it eventually freed the memory and the system started working normal again.
I deleted the rest of the files using the Windows Explorer without strange effects.


A while later I once again had to delete a certain amount of file s (around 12 GB of data this time). And once again TC started to used abnormal amounts of RAM (upwards of 2 GB).
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

2esque,

This is a known problem.
At least "VistaDelete=1" (F1,4.b wincmd.ini) can speed up the deletion of complete folders.
You should give this setting a try.

Regards
Holger
muzungu
Junior Member
Junior Member
Posts: 2
Joined: 2010-06-23, 08:51 UTC

Re: [TC 8.0b5 x64] high memory usage when deleting files

Post by *muzungu »

Yes, I confirm this behavior too and I believe it is a bug. HolgerK's advice works. Nonetheless this might be fixed.
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

muzungu wrote:and I believe it is a bug.
It's not. Ghisler explained already that it's a problem in Windows itself: Microsoft changed the way files are deleted (now each file is processed in a separate thread; with many files it requires lots of resources). TC now uses VistaDelete=1 by default.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Flint wrote:TC now uses VistaDelete=1 by default.
I guess you mean this
ghisler(Author) wrote:Therefore the next version of TC will use VistaDelete=1 by default on Windows Vista/7
2ghisler(Author)
Actually VistaDelete is deactivated in TC8.0b6.
Do you still consider to change the default to VistaDelete=1?

Regards
Holger
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50479
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually I disabled VistaDelete=1 because it caused troubles on Windows 8 beta. But this is fixed now, so I will re-enable it.
Author of Total Commander
https://www.ghisler.com
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Thanks for the info.

Regards
Holger
Make our planet great again
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

I can confirm that VistaDelete is now default 1 in Windows 7 and Vista.

But the new Default for Vista/Win7 is still not mentioned in Help 4.b wincmd.ini.

Regards
Holger
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hm, seems as if we ignored the potential side effect of changing the default value to VistaDelete=1 in cases where "Ask for confirmation" has been disabled in the recycle bin properties, cf. TC80ß7x32 deletes without inquiry. :oops:

Karl
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Hmmh. Don't know if this side effect is only a move to recycle bin without confirmation (guess some other users would be happy to know a way to disable the delete confirmation in TC) or a really big bug where data are lost by accidentally pressing <del>.
I've read the arguments of JOUBE, but if he wants consistence at any price, why did he disable the delete confirmation of windows, and why is it such a big problem to set VistaDelete back to 0?
On the other side, if i remember well, some users are complaining about a totally unresponsive OS while deleting a huge amount of files (someone might press the reset button in this case and really run into trouble).

Regards
Holger
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

Hello, HolgerK.

As explained in that other thread:
The default value of VistaDelete has changed from inactive (0) to active (1).
This change will be effective the moment that you launch T.C. 8.0ß7 for the very first time without the user knowing.
Why?
Pretty simple: Most users will never have bothered to add VistaDelete to their wincmd.ini. So the default value is used. Before updating beta6 to beta7 the default was VistaDelete=0, now it is VistaDelete=1.
Now simply imagine that someone has forgotten that he has disabled the Windows recycle bin confirmation dialogue.
Up to T.C. 8.0ß6 T.C. would ask for confirmation before deleting. With VistaDelete=1 Windows would ask for confirmation had it not been instructed not to do so. Ouch.
In the better case, Windows is still configured to delete to the recycle bin. So chances are good to restore from there.
In the worst case, Windows has been configured to delete directly and not to ask for confirmation. Press DEL in T.C. with VistaDelete=1 and say byebye to your data.
You will be delighted in particular if you pressed DEL on the wrong file(s) or folder(s) by mistake.

The nasty thing is that your foolish recycle bin configuration may hit you right after updating to T.C. 8.0ß7 provided you are on Vista/Win7/Server 2008/Server 2008 R2.
T.C. changes the default value of the delete method it uses on these platforms and thereby loses control over the confirmation dialogue. And all this without telling you beforehand that it is going to do so and without instructing you to (re-)enable the Windows recycle bin confirmation dialogue.

We don't really believe that the majority of users who install a new beta version take the pain of going through the history.txt beforehand. Personally I read it after installing.

This is why in that other thread wrote that my preferred way out of this situation would be to revert back to VistaDelete=0 as the default and a nice and simple tickbox in the configuration box where you can tick or untick [_] VistaDelete (faster on Vista and higher. If you tick VistaDelete, re-enable this bloody recycle bin confirmation dialog to avoid data loss)

I'd rather explain how to activate VistaDelete=1 to another two dozen users who complain about deleting being too slow than being forced to explain that he should have re-activated the recylcle bin confirmation dialog before pressing DEL on the wrong file/folder.

Kind regards,
Karl
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

HolgerK wrote:I can confirm that VistaDelete is now default 1 in Windows 7 and Vista.
Confirmation confirmed. :wink:

Tested on
Server 2008 R2
Total Commander 8.0ß7 32-bit and 64-bit

Karl
User avatar
HolgerK
Power Member
Power Member
Posts: 5409
Joined: 2006-01-26, 22:15 UTC
Location: Europe, Aachen

Post by *HolgerK »

Most users will never have bothered to disable the delete confirmation in windows.

Alternative solution:
Only activate Vistadelete automatically under the condition that the delete confirmation is not turned off.

Regards
Holger
User avatar
karlchen
Power Member
Power Member
Posts: 4605
Joined: 2003-02-06, 22:23 UTC
Location: Germany

Post by *karlchen »

HolgerK wrote:Most users will never have bothered to disable the delete confirmation in windows.
Protect the minorities! :wink:
Only activate Vistadelete automatically under the condition that the delete confirmation is not turned off.
Good idea. Anything will be welcome that will make sure automatically using a default value, VistaDelete=1, will not automatically disable the only confirmation dialog left.

Karl
User avatar
kfft
Junior Member
Junior Member
Posts: 21
Joined: 2010-12-26, 01:17 UTC

Post by *kfft »

can't we modify the Bin option directly in TC?
There must be a way to read/write this option calling some functions no?
Post Reply