[TC 8.0ß6] Unable to save shortcut in some cases

The behaviour described in the bug report is either by design, or would be far too complex/time-consuming to be changed

Moderators: Hacker, petermad, Stefan2, white

AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

[TC 8.0ß6] Unable to save shortcut in some cases

Post by *AndrewCreator »

Steps to reproduce:

1) Redirect [Shortcuts] section to other file
[Shortcuts]
RedirectSection=%COMMANDER_PATH%\conf\shortcuts.ini

2) Launch TC and add some shortcuts. They will be saved in shortcuts.ini.

3) Close TC and made the wincmd.ini read-only.

4) Launch TC and try to add some shortcuts. You will not be able to do this in spite of shortcuts.ini is not read-only.
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3378
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

It would be nice if you can add WICH version of TC8pb6 you use 32- or 64-Bit (and wich OS)
Hoecker sie sind raus!
User avatar
petermad
Power Member
Power Member
Posts: 16031
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2AndrewCreator

I cannot confirm this with neither 64bit nor 32bit version of TC 8.0b6.

Maybe it is because the shortcuts you try to add involves the Win key - in that case you also have to redirect the [ShortcutsWin] section:

[ShortcutsWin]
RedirectSection=%COMMANDER_PATH%\conf\shortcuts.ini

Also - remember to click the green checkmark button after you have remapped the key.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

2Sir_SiLvA,
Windows XP SP3 32-bit.

2petermad,
Thank you for reminding about green check mark. I can confirm that if wincmd.ini is not read-only there is no need to press it. But if it is read-only then the changes to shortcuts.ini will not be saved until you press it.
User avatar
petermad
Power Member
Power Member
Posts: 16031
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

if wincmd.ini is not read-only there is no need to press it. But if it is read-only then the changes to shortcuts.ini will not be saved until you press it.
I can confirm that. But of course if you change more than one key at the same time, and don't use the checkmark button, then it is only the last change that gets saved when wincmd.ini is not read-only.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

2petermad,

I think the best solution is to save shortcut immediately after clicking "OK" in "Choose command" dialog.
User avatar
petermad
Power Member
Power Member
Posts: 16031
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2AndrewCreator
That's what I always do - hence I couldn't confirm your report at first.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

petermad,

Sorry, I meant that it would be nice if shortcut is automatically saved immediately after clicking "OK" in "Choose command" dialog, without clicking green check mark.
User avatar
petermad
Power Member
Power Member
Posts: 16031
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I agree.

I think the green checkmark buton is a reminiscence from the time when there was no dialog box, but only a dropdown list for picking commands (before TC 7.0).

Now it seems to be redundant and could be removed. OK in the command selection dialog should be enough.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

May be this should be moved to suggestions forum?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50532
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

It seems that TC stops saving settings when the wincmd.ini is read only. I will check whether I can somehow save these settings anyway.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16031
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

It is only partly fixed in TC 8.0b7.

Now, if I make a keyboard remapping, and just click OK in the main Configuration dialog, then I get the message that wincmd.ini is write protected, when it is really the file redirected to, which is write protected.

If I click the green checkmark button after making a change, then I don't even get a warning about the write protection! - the change is simply silently not made!

IMHO the best would be if an option to save the change despite of the write protection would be shown when both the OK and the checkmark button is clicked after makin a change to the remapping
Last edited by petermad on 2011-10-29, 19:10 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
AndrewCreator
Member
Member
Posts: 122
Joined: 2011-10-10, 23:25 UTC

Post by *AndrewCreator »

Hm, why not use the simplest and logical solution?

1) Remove green mark.
2) Try to save after clicking OK in selection window.
3) If file where shortcuts are saved is write protected show the warning message telling that this file is write protected (either wincmd.ini or file_where_shortcuts_are_stored.ini).
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50532
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2petermad

You should get that warning, but the settings should still be stored!
Author of Total Commander
https://www.ghisler.com
User avatar
Flint
Power Member
Power Member
Posts: 3506
Joined: 2003-10-27, 09:25 UTC
Location: Belgrade, Serbia
Contact:

Post by *Flint »

AndrewCreator wrote:Hm, why not use the simplest and logical solution?

1) Remove green mark.
It would require to press Apply after each hotkey.
Flint's Homepage: Full TC Russification Package, VirtualDisk, NTFS Links, NoClose Replacer, and other stuff!
 
Using TC 11.03 / Win10 x64
Post Reply