+Lister, search hex - search text replaced in edit field

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

+Lister, search hex - search text replaced in edit field

Post by *MarcinW »

Steps to reproduce (TC 8.50 RC2 32-bit):
1) Open with Lister some file, that has many bytes from range 0x00..0x1F (for example some EXE/DLL/ZIP file).
2) Press F7, select "Search hex string" option, enter search text "9" (without quotes) and press Enter.
3) Now Lister goes to the byte found (if "Not found" message appears, try with another file).
4) Press F7 again - now "9" is replaced with " ", which is a visual representation of Tab character.

Some other replacements:
- "0" is replaced with empty string,
- "1" is replaced with "".
Fossi
Junior Member
Junior Member
Posts: 59
Joined: 2005-03-29, 11:35 UTC
Location: Bärenhöhle

Post by *Fossi »

I can reproduce it. The same with TC 8.50 RC2 64 Bit.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I will check it.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

OK, it wasn't really a bug - when you press F7, TC simply takes the SELECTED TEXT as the search string.

In RC3, I have changed this now: The selected text is only used for F7 when the user has selected it manually, not when it was selected by the search function. This way, the previous search text will be preserved. This is only relevant when the search result differs from the search text, e.g. for hex or regex.
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5815
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Post by *white »

Tested OK using TC8.50rc3 32bit.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
User avatar
MarcinW
Power Member
Power Member
Posts: 852
Joined: 2012-01-23, 15:58 UTC
Location: Poland

Post by *MarcinW »

Problem fixed in RC3 (I tested 32-bit only). Thanks!
Post Reply