FTP - Download from list (rename bug)

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

krasusczak
Senior Member
Senior Member
Posts: 284
Joined: 2011-09-23, 10:35 UTC

FTP - Download from list (rename bug)

Post by *krasusczak »

Hi, I have found one problem, maybe someone already post it here but I don't have time to check it right now..


OS: XP 32bit, TC: 8.51a
If you use FTP & Download from list option (from ftplist.txt file) & address on that list will looks like this:
http://something.com/test/01.jpg
..
http://something.com/test/10.jpg
http://something.com/test2/01.jpg
..
http://something.com/test2/10.jpg

When you download all 10 files from "test" & starts download "test2" TC will find same file name, so will show question abort/rename etc, & when you choose rename whole total commander just hangs permanently.., sometimes you need to wait a few seconds at rename window to get this results..:/
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

I can not confirm this, for FTP at least. TC shows the normal dialog to overwrite/rename/etc and if you choose rename there, TC asks for a new file name in a new dialog. Maybe this dialog is somewhere not immediately visible (below other windows in the Z-order)?

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
krasusczak
Senior Member
Senior Member
Posts: 284
Joined: 2011-09-23, 10:35 UTC

Post by *krasusczak »

Hmm this is not true FTP, I don't know how to describe this but if you use extended English menu you choose FTP->"Download From List" & there you choose your txt list from your computer with all download links, so you probably checking in the wrong section:P
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

2krasusczak
No, I'm not doing anything wrong. There's no need for extended menus since the TC standard menus already have "Download from List" available. Which is exactly the one I've used.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Btw, you can use the following to explicitly set the target name:
http://something.com/test2/10.jpg -> test2_10.jpg
Author of Total Commander
https://www.ghisler.com
krasusczak
Senior Member
Senior Member
Posts: 284
Joined: 2011-09-23, 10:35 UTC

Post by *krasusczak »

@ghisler
ok, that works but without this I can every time reproduce this error for example at this links in ftplist.txt:

http://101tema.ru/gallery2/main.php/d/10170-2/001.jpg
http://101tema.ru/gallery2/main.php/d/10171-2/001.jpg


1. download from link to c:\ for ex.
2. after first file download & question windows appear & before you choose rename, click first at background transfer manager window "100% 001.jpg (Download)" & then when you click rename application will hang completely.. confirmed also at Win7




szAppName : TOTALCMD.EXE szAppVer : 8.5.1.1 szModName : hungapp
szModVer : 0.0.0.0 offset : 00000000
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

2krasusczak
Can you reproduce this issue with a stock TC and a fresh wincmd.ini? If so, can you provide step-by-step instructions what exactly needs to be done to reproduce it?

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
krasusczak
Senior Member
Senior Member
Posts: 284
Joined: 2011-09-23, 10:35 UTC

Post by *krasusczak »

Because I have over 150 plugins etc I don't have time now to reinstall stock TC but I just renamed plugins directory & make "0" wincmd.ini I hope it's enough & yes I still can reproduce this error


Step-by-Step:
Image: http://oi59.tinypic.com/r05hjt.jpg


ftplist.txt src:
"
http://101tema.ru/gallery2/main.php/d/10170-2/001.jpg
http://101tema.ru/gallery2/main.php/d/10171-2/001.jpg
"
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

OK, I can reproduce it now, but with HTTP downloads only! And, one must click on the background transfer manager before clicking "Rename" in the open dialog.

Trying to reproduce this issue, I discovered that the dialog is different on HTTP and FTP downloads. While it pops up centered/parented on the TC main window for FTP downloads, it's centered/parented on the BTM for HTTP downloads. That may be the trigger (or even the cause) for this issue/bug.

Curiously, the cursor still blinks normally in the Rename dialog, although it doesn't react to any input, mouse or keyboard.

Regards
Dalai
Last edited by Dalai on 2015-07-20, 16:48 UTC, edited 1 time in total.
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
krasusczak
Senior Member
Senior Member
Posts: 284
Joined: 2011-09-23, 10:35 UTC

Post by *krasusczak »

Dalai wrote: Curiously, the cursor still blinks normally in the Rename dialog, although it doesn't react to any input, mouse or keyboard.
Exactly

Dalai wrote:And, one must click on the background transfer manager before clicking "Rename" in the open dialog.
Nope I can't agree with it, you don't need to click rename button before (yes it helps get error quickly..), but if you don't do this & you click rename button - rename window will pop-up & work "OK".
You can even try change name, but this "OK" will be only for a few seconds, when you wait this few seconds background transfer manager will refresh itself & kill TC.... (please try it).
I think that this is problem with background transfer manager refreshing..:/



@edit:
from what I tested now 2nd method works only at XP, on 7 wont crush..
Last edited by krasusczak on 2015-07-20, 16:00 UTC, edited 1 time in total.
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6975
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp »

krasusczak wrote:Because I have over 150 plugins etc I don't have time now to reinstall stock TC but I just renamed plugins directory & make "0" wincmd.ini I hope it's enough & yes I still can reproduce this error
...
"
Next time you want such a test start TC with parameter like
/i=fresh.ini
and you have a stock TC with no plugins or changed settings.
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

krasusczak wrote:Nope I can't agree with it, you don't need to click rename button before (yes it helps get error quickly..), but if you don't do this & you click rename button - rename window will pop-up & work "OK".
You can even try change name, but this "OK" will be only for a few seconds, when you wait this few seconds background transfer manager will refresh itself & kill TC.... (please try it).
I tried it, and I can't reproduce it this way (I waited ~10 seconds). You have to at least switch tasks (Alt+Tab) or click on the BTM to trigger this issue. There may be more to it since the BTM may react to messages sent by other windows (which may be the case on your system). But only Ghisler can answer this, although he doesn't need to as it is enough if the bug is fixed ;).

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

You may need to use Alt+Tab to activate the rename dialog, because it is part of TC, not the background transfer manager.
Author of Total Commander
https://www.ghisler.com
User avatar
Dalai
Power Member
Power Member
Posts: 9966
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

2ghisler(Author)
It's NOT a problem to activate the rename dialog! It IS active, and the cursor blinks in the rename dialog. The issue that the dialog and every window of that TC instance doesn't react to any input. It's just frozen and must be killed using task manager or by clicking on the [X] of the BTM.

So far I can only reproduce it with the steps krasusczak provided in the screenshot, and only with HTTP downloads, even on Win7. Just try it yourself. It is reproducible, and it is a problem.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
Gral
Power Member
Power Member
Posts: 1600
Joined: 2005-01-26, 15:12 UTC

Post by *Gral »

I don't understand why this very old bug is still not fixed in TC 8.52 beta.
Some new bugs (occurs ONLY on Windows 10) are fixed immediately, while this one (and many more) waiting for TC 9 (or higher?).
Post Reply