Internal context menu: wrong WCX used or wrong info from TC

Please report only one bug per message!

Moderators: white, sheep, Hacker, Stefan2

Post Reply
User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Internal context menu: wrong WCX used or wrong info from TC

Post by *DrShark » 2015-12-03, 21:23 UTC

To reproduce:
0. Start TC with clean (default) main settings ini.
1. Install 7zip plugin registered to 7z extension and Total7zip plugin registered for total7zip extension, then make an internal association by instruction from this post. Or, just use Configuration, Change ini files directly, put following custom settings into default wincmd.ini:

Code: Select all

[PackerPlugins]
7z=C:\your\path\to\7z.wcx
total7zip=C:\your\path\to\Total7zip.wcx
[Associations]
Filter1=*.7z
Filter1_total7zip=**total7zip
Save file and close it.
2. Restart TC with this ini to make sure changed settings will be applied.
3. Find *.7z archive, use its context menu item "total7zip". TC will open archive.
4. Press Alt+Enter inside archive on some file, in its properties you'll see field "Packer: 7z". If "Packer:" field doesn't lie here, it is an indication that wcx plugin registered for 7z extension in [PackerPlugins] used when total7zip menu called.
Expected behaviour:
ghisler(Author) wrote:If you open a file via **total7zip verb, TC should then use total7zip and not other unpacker defined for that extension.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
petermad
Power Member
Power Member
Posts: 8032
Joined: 2003-02-05, 20:24 UTC
Location: Valsted, Denmark
Contact:

Post by *petermad » 2015-12-03, 21:32 UTC

Press Alt+Enter inside archive on some file, in its properties you'll see field "Packer: 7z"
I think that field indicates the archive type of the packed file - NOT what kind of application that is currently opening it...
License #524
Danish Total Commander Translator
TC 9.21a 32+64bit on Win XP 32bit, Win 7, 8.1 & 10 64bit and TC 2.91 on Android 6.0
Get Extended Total Commander Menus | PHSM-Calendar

User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2015-12-03, 21:41 UTC

petermad wrote:
Press Alt+Enter inside archive on some file, in its properties you'll see field "Packer: 7z"
I think that field indicates the archive type of the packed file - NOT what kind of application that is currently opening it...
No. Just install one wcx plugin: total7zip, registered for total7zip extension and the field will be "Packer: total7zip". Or if you don't have plugins, just open 7z archive with Enter key and you will see "Packer:7zip (dll)", an indication that internal unpacker used.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
Gral
Power Member
Power Member
Posts: 643
Joined: 2005-01-26, 15:12 UTC

Re: Internal context menu: wrong WCX used or wrong info from

Post by *Gral » 2015-12-04, 05:22 UTC

 

This bug was reported over 4 years ago -> http://www.ghisler.ch/board/viewtopic.php?p=220345#220345 but no reply from Ghisler.
(I noticed this behaviour myself too, and i use workaround all this time!)

 

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2015-12-07, 10:26 UTC

This is just a minor display error. Sorry, I will not spend hours and hours on that. It's also debatable whether this is the right thing to show - currently the dialog is independent, it just checks what plugin is responsible by default for a certain file.
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2015-12-07, 12:34 UTC

ghisler(Author) wrote:This is just a minor display error. Sorry, I will not spend hours and hours on that. It's also debatable whether this is the right thing to show - currently the dialog is independent, it just checks what plugin is responsible by default for a certain file.
I can't agree that it's just a display error. In example from start post, change path to 7zip.wcx to some non-existing location, so it will be like that:

Code: Select all

[PackerPlugins]
7z=C:\fictional\path\to\7z.wcx
total7zip=C:\real\path\to\Total7zip.wcx
When using context menu item "total7zip", TC will show following error:

Code: Select all

---------------------------
Total Commander
---------------------------
Error, could not load plugin!

C:\fictional\path\7z.wcx
---------------------------
ОК   
---------------------------
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Re: Internal context menu: wrong WCX used or wrong info from

Post by *DrShark » 2017-02-26, 21:50 UTC

2Gral
Gral wrote:This bug was reported over 4 years ago -> http://www.ghisler.ch/board/viewtopic.php?p=220345#220345 ... and i use workaround all this time!
What workaround did you mean? Like changing file extension (*.msi2 example in the post from your link)?
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2017-03-22, 17:22 UTC

history.txt wrote:27.04.16 Fixed: Internal associations: Allow to override also internal unpackers with **packerplugin, e.g. for 7z, not only define additional extensions (32/64)
Seems to be fixed in 9.0, although I'd like to see some improvements.
Test configuration:

Code: Select all

[Associations]
Filter1=*.7z
Filter1_Total7zip=**Total7zip
Filter1_InternalTC7ZDLL=**TC7ZDLL
[PackerPlugins]
7z=207,c:\test\7z.wcx
total7zip=735,C:\test\Total7zip.wcx
TC7ZDLL=c:\totalcmd\TC7Z.DLL
Here TC 9.0 allows to use Internal Context menu items for second and later filters set in [Associations]: they work if they are valid wcx unpackers and the info in "Packer:"field from Alt+Enter window is correct.
The things I'd like to see improved:
1. Currently there in no Internal context menu item for Filter1=*.7z from [Associations]. It just works with Enter or Ctrl+PgDn. I'd like to see "Default (*.7z)" as a first context menu item.
2. I tried to add an internal TC7Z.DLL as the unpacker for internal context menu as last item (see example config above), but when tried to use it, TC showed an error:

Code: Select all

---------------------------
Total Commander
---------------------------
Error, could not load plugin!

c:\totalcmd\TC7Z.DLL
---------------------------
ОК   
---------------------------
Is there a way to use to use internal 7zip unpacker as a wcx plugin? If no, can this be added to TC7Z.DLL in future?
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 36425
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2017-03-23, 10:05 UTC

No, you can't use internal 7zip unpacker when using a 7zip plugin. What would be the benefit? It can't do more than the plugin...
Author of Total Commander
http://www.ghisler.com

User avatar
DrShark
Power Member
Power Member
Posts: 1111
Joined: 2006-11-03, 22:26 UTC
Location: Kyiv, 68/262

Post by *DrShark » 2017-03-23, 13:23 UTC

ghisler(Author) wrote:No, you can't use internal 7zip unpacker when using a 7zip plugin. What would be the benefit? It can't do more than the plugin...
Internal unpacker is expected to be more stable.
Android 4.3.1 no root, kernel 08.09.2016; Vista Home Premium SP2 rus 32 bit
TC #149847 Personal licence

Cuz we're all in this together, We're here to make it right

Post Reply