[9.0b10] Pressing F4 in FindFiles dialog

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
wanderer
Power Member
Power Member
Posts: 1640
Joined: 2003-03-28, 14:35 UTC
Location: Sol

[9.0b10] Pressing F4 in FindFiles dialog

Post by *wanderer »

ALT + F7, search for some text in files. Selecting a file and pressing F4 opens the file in an editor. Fine so far. If you close and reopen the FindFiles dialog, the "search for" combo is active. When F4 is pressed, the combo gets expanded (because F4 does that for all combos) but since a file is selected in the list, it also opens the files.

IMO, either the combo should not be expanded or the file should not be opened in the editor if the active control is the combo.

It's not a big thing but IMO the file should not be edited in that case (when the combo is the active control). F4 should just expand the combo.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3 (very rarely nowadays).
x64: Clients/Servers - Win10/Win11 and Win2K16 to Win2K22, mainly Win10 though.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks, I didn't know that F4 had a meaning for comboboxes. I will restrict F4 to when the cursor is in the result list.
Author of Total Commander
https://www.ghisler.com
User avatar
wanderer
Power Member
Power Member
Posts: 1640
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

ghisler(Author) wrote:Thanks, I didn't know that F4 had a meaning for comboboxes. I will restrict F4 to when the cursor is in the result list.
Perhaps this is more accurate but IMO it might be better if you restricted F4 to work when the cursor is NOT on a control of type combobox. Some may find it useful to have F4 working even when another button has been pressed via the mouse and is currently the active control...
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3 (very rarely nowadays).
x64: Clients/Servers - Win10/Win11 and Win2K16 to Win2K22, mainly Win10 though.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50550
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

I changed it as you suggested, please try with beta 12 or 13!
Author of Total Commander
https://www.ghisler.com
User avatar
wanderer
Power Member
Power Member
Posts: 1640
Joined: 2003-03-28, 14:35 UTC
Location: Sol

Post by *wanderer »

Yup, seems better now (tried b13). Thanks.
- Wanderer -

¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯¯
Normally using latest TC on:
x32: WinXPx32 SP3 (very rarely nowadays).
x64: Clients/Servers - Win10/Win11 and Win2K16 to Win2K22, mainly Win10 though.
Post Reply