[TC 9.0rc3, 8.52a] TC hang with quick view and quick search

Bug reports will be moved here when the described bug has been fixed

Moderators: Stefan2, white, sheep, Hacker

Post Reply
User avatar
MaxX
Power Member
Power Member
Posts: 652
Joined: 2012-03-23, 18:15 UTC
Location: Earth

[TC 9.0rc3, 8.52a] TC hang with quick view and quick search

Post by *MaxX » 2016-10-31, 16:51 UTC

You'll need:
1. TC 8.52a or TC 9.0 rc3
2. sLister.wlx + SumatraPDF.exe
3. some PDF files

To do:
1. Start TC
2. Go into some dir with PDF files
3. Open quick view mode by Ctrl+Q (cursor is on highest ".." position)
4. Open small quick search box via [cm_ShowQuickSearch] or hotkey
5. Type some first letters of any existing file
6. (now TC moves cursor to one of these PDF and hangs)

Tested combinations :
TC32 8.52a + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 32-bit
TC64 8.52a + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 64-bit
TC64 9.0rc3 + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 64-bit

Don't know, is that a bug in TC or in plugin, but it makes TC unusable until taskkill...

User avatar
Horst.Epp
Power Member
Power Member
Posts: 3275
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp » 2016-10-31, 17:33 UTC

Confirmed with TC 9.0 RC3 x64
SLister 1.1.2.0, SumatraPDF 3.1.2 x64
It happens only when starting the search from the ...
Windows 10 Home x64 October 2018 Update, Version 1809 (OS Build 17763.437)
Intel(R) Core(TM) i7-4770 CPU @ 3.40GH, 16GB RAM
TC 9.22a x64 and x86, Everything 1.4.1.939 (x64)

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 37170
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2016-10-31, 20:28 UTC

Unfortunately it is a plugin bug, and there is nothing I can do about it. I already added a fix for a similar problem:

26.10.16 Fixed: Close quick search dialog when user presses Ctrl+Q, otherwise some plugins like SLister can hang Total Commander (32/64)

But I can't just disable quick search every time you press a key in it while quick view is up, that would make it unusable. So far only sLister is causing this problem.
Author of Total Commander
http://www.ghisler.com

User avatar
MaxX
Power Member
Power Member
Posts: 652
Joined: 2012-03-23, 18:15 UTC
Location: Earth

Post by *MaxX » 2016-11-01, 20:13 UTC

Understood.
Next try...

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 37170
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2016-11-02, 20:21 UTC

Actually I found a solution now:
1. Disallow closing of quick search window
2. Set focus in active file list
3. Load file via plugin
4. Handle all pending windows messages
5. Set focus back in quick search window
6. Handle all pending windows messages
7. Allow closing of quick search window

This method also works when user presses Ctrl+Q in quick search, so I no longer have to close it to prevent the hang.
Author of Total Commander
http://www.ghisler.com

User avatar
MaxX
Power Member
Power Member
Posts: 652
Joined: 2012-03-23, 18:15 UTC
Location: Earth

Post by *MaxX » 2016-11-02, 22:35 UTC

2ghisler(Author)
Lots of thanks!
RC4 works fine now!

User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 37170
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) » 2016-11-03, 14:54 UTC

Well, the fix had one negative side effect:
http://ghisler.ch/board/viewtopic.php?t=46252

But that will be easy to fix.
Author of Total Commander
http://www.ghisler.com

Post Reply