[TC 9.0rc3, 8.52a] TC hang with quick view and quick search

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

[TC 9.0rc3, 8.52a] TC hang with quick view and quick search

Post by *MaxX »

You'll need:
1. TC 8.52a or TC 9.0 rc3
2. sLister.wlx + SumatraPDF.exe
3. some PDF files

To do:
1. Start TC
2. Go into some dir with PDF files
3. Open quick view mode by Ctrl+Q (cursor is on highest ".." position)
4. Open small quick search box via [cm_ShowQuickSearch] or hotkey
5. Type some first letters of any existing file
6. (now TC moves cursor to one of these PDF and hangs)

Tested combinations :
TC32 8.52a + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 32-bit
TC64 8.52a + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 64-bit
TC64 9.0rc3 + sLister.wlx 1.1.2.0 + SumatraPDF.exe 3.1.1.0.10417z + Win7 SP1 64-bit

Don't know, is that a bug in TC or in plugin, but it makes TC unusable until taskkill...
User avatar
Horst.Epp
Power Member
Power Member
Posts: 6492
Joined: 2003-02-06, 17:36 UTC
Location: Germany

Post by *Horst.Epp »

Confirmed with TC 9.0 RC3 x64
SLister 1.1.2.0, SumatraPDF 3.1.2 x64
It happens only when starting the search from the ...
Windows 11 Home x64 Version 23H2 (OS Build 22631.3527)
TC 11.03 x64 / x86
Everything 1.5.0.1373a (x64), Everything Toolbar 1.3.3, Listary Pro 6.3.0.73
QAP 11.6.3.2 x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Unfortunately it is a plugin bug, and there is nothing I can do about it. I already added a fix for a similar problem:

26.10.16 Fixed: Close quick search dialog when user presses Ctrl+Q, otherwise some plugins like SLister can hang Total Commander (32/64)

But I can't just disable quick search every time you press a key in it while quick view is up, that would make it unusable. So far only sLister is causing this problem.
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

Understood.
Next try...
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually I found a solution now:
1. Disallow closing of quick search window
2. Set focus in active file list
3. Load file via plugin
4. Handle all pending windows messages
5. Set focus back in quick search window
6. Handle all pending windows messages
7. Allow closing of quick search window

This method also works when user presses Ctrl+Q in quick search, so I no longer have to close it to prevent the hang.
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

2ghisler(Author)
Lots of thanks!
RC4 works fine now!
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48083
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Well, the fix had one negative side effect:
http://ghisler.ch/board/viewtopic.php?t=46252

But that will be easy to fix.
Author of Total Commander
https://www.ghisler.com
Post Reply