[solved] TC 9.5b5 - Inconsistant implementation of delete to recycle bin

[petermad]

Applies to Windows Vista -> Windows 10
Scenario 1:
1. Set VistaDelete=-1 in wincmd.ini.
2. Enable "F8/Del deletes to recycle bin (shift=directly)" in the "Copy/Delete" configuration.
3. Enable the Recycle bin for the current drive (right click on the Recycle bin icon on the desktop an choose Properties).
4. Disable "Display delete confirmation dialog" for the Recycle bin.
5. Pres Delete on a file - TC asks in its own dialog whether to move the file to recycle bin.
6. Press OK and the file is moved to recycle bin.
7. Press Shift+Delete - TC asks to permanently delete the file.
8. Press OK and the file is deleted.
This is all as expected.

Scenario 2:
1. Set VistaDelete=-1 in wincmd.ini.
2. Disable "F8/Del deletes to recycle bin (shift=directly)" in the "Copy/Delete" configuration.
3. Enable the Recycle bin for the current drive (right click on the Recycle bin icon on the desktop an choose Properties).
4. Disable "Display delete confirmation dialog" for the Recycle bin.
5. Pres Delete on a file - TC asks to permanently delete the file.
6. Press OK and the file is deleted - as expected
7. Press Shift+Delete - TC asks in its own dialog whether to move the file to recycle bin.
8. Press OK and a Windows dialog box asks to permanently delete the file!
9. Press Yes and the file is deleted.
It is unexpected that Windows' dialog is shown and that is asks to delete permanently - I would expect moving to recycle bin as TC asks in 7.

10. Now enable "Display delete confirmation dialog" for the Recycle bin.
11. Press Shift+Delete again on a file.
12. TC does not ask to move the file to recycle bin as in 7.
13. A Windows dialog box asks to move the file to recycle bin.
14. Press Yes - and the file is moved to recycle bin - as expected.

Why this difference in Scenario 1 and 2? - I would expect that the function is simply reversed when I disable "F8/Del deletes to recycle bin (shift=directly)" - so that a press on Delete will simply delete the file (as i also does) and that Shift+Delete would simply make TC ask to move the file to recycle bin, without any confirmation boxes from Windows.

And I would certainly not expect that changing the "Display delete confirmation dialog" for the Recycle bin would change whether Window will permanently delete or move to Recycle bin.

NOTE: If VistaDelete=1 - everything works as expected with all combinations of "F8/Del deletes to recycle bin (shift=directly)" and "Display delete confirmation dialog" for the Recycle bin.

[Hacker]

petermad,
I guess there is a typo, you have two "Scenario 1"'s.

Roman

[ghisler(Author)]

8. Press OK and a Windows dialog box asks to permanently delete the file!

This is indeed a bug - it happens only when you release the Shift key before the Explorer dialog comes up.

12. TC does not ask to move the file to recycle bin as in 7.
13. A Windows dialog box asks to move the file to recycle bin.

This is intentional: When using the Explorer delete method (VistaDelete!=0), then it should be the Explorer showing the delete confirmation. TC only shows it in scenario 1 because the Explorer conformation dialog was disabled, and due to the bug not deleting to recycle bin.

[petermad]

I guess there is a typo, you have two "Scenario 1"'s.

Yes, sorry - corected now

8. Press OK and a Windows dialog box asks to permanently delete the file!

This is indeed a bug - it happens only when you release the Shift key before the Explorer dialog comes up.

If I keep the Shift key down until I have pressed the Yes button in TC's dialog, then the file is still permanently deleted in stead of being moved to recycle bin as it should - but there is no Explorer dialog shown then.

So there are 2 bugs:
1. Showing the Explorer dialog.
2. Permanently deleting in sted of moving the file.

[petermad]

Confirmed fixed in TC9.5b6 But it is not documented in history.txt

[ghisler(Author)]

What needs to be documented? It's just a bugfix, not a new feature.

[petermad]

I am talking about history.txt - it documents all kinds of fixes - I am not talking about the What's New in Help or at https://www.ghisler.ch/board/viewtopic.php?f=3&t=54942

[ghisler(Author)]

Ah, I see, must have missed it.

[petermad]

history.txt:

15.11.19 Fixed: With VistaDelete=-1 and "F8/Del deletes to recycle bin" disabled and no Windows delete confirmation dialog, Shift+Del on a file
didn't delete to recycle bin (32/64)

So, confirmed fixed in TC 9.5b7