Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
Moderators: Hacker, petermad, Stefan2, white
Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
To reproduce:
1. Start or switch TC to dark mode.
2. Start copying of some big file, so you'll have enough time to press buttons in Copy progress dialog.
3. Press "Pause" button with keyboard (Shift+Tab, Enter): it will become a light-themes "Start" button.
Pressing "Start" button with keyboard will turn it to a light-themed "Pause" button.
Reproduced using Total Commander 9.50 RC1, Vista 32-bit with classic theme.
1. Start or switch TC to dark mode.
2. Start copying of some big file, so you'll have enough time to press buttons in Copy progress dialog.
3. Press "Pause" button with keyboard (Shift+Tab, Enter): it will become a light-themes "Start" button.
Pressing "Start" button with keyboard will turn it to a light-themed "Pause" button.
Reproduced using Total Commander 9.50 RC1, Vista 32-bit with classic theme.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Ukraine's National Bank special bank account:
UA843000010000000047330992708
- ghisler(Author)
- Site Admin
- Posts: 50532
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
Unfortunately there are a few problems with classic theme which cannot be fixed easily. For example, when you press the Alt key in a dialog, some buttons may get a light text overlayed. This happens when Windows draws on the button bypassing the WM_PAINT message, so I don't get the chance to overdraw the white text with dark.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
It's fixed for original conditions in TC 9.50 RC2, but now if after pressing Start/Pause to press Cancel button, thehistory950.txt wrote:28.01.20 Fixed: Dark mode, classic theme: Pause copying with ENTER on Pause button showed normal (not dark) pause/start button (32/64)
Code: Select all
---------------------------
Total Commander
---------------------------
User abort!
---------------------------
OK Cancel
---------------------------
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Ukraine's National Bank special bank account:
UA843000010000000047330992708
- ghisler(Author)
- Site Admin
- Posts: 50532
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
I have seen that too, but didn't fix it because it goes away when you click OK or Cancel.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
Sometimes it doesn't, and it doesn't look nice anyway, so please consider fixing this too.ghisler(Author) wrote: 2020-01-30, 11:00 UTC I have seen that too, but didn't fix it because it goes away when you click OK or Cancel.
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
This is fixed in TC 9.50a RC1 (uncredited bugfix).DrShark wrote: 2020-01-30, 09:09 UTCif after pressing Start/Pause to press Cancel button, thedialog will appear and Start/Pause button will again become light.Code: Select all
--------------------------- Total Commander --------------------------- User abort! --------------------------- OK Cancel ---------------------------
Donate for Ukraine to help stop Russian invasion!
Ukraine's National Bank special bank account:
UA843000010000000047330992708
Ukraine's National Bank special bank account:
UA843000010000000047330992708
- ghisler(Author)
- Site Admin
- Posts: 50532
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Re: Dark Mode, Copy progress dialog: Pause/Start button becomes light if pressed with keyboard
Thanks - I think I sent you an e-mail that I fixed this.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com