solved [TC 11.00b1] cannot escape new history list under certain circumstances

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 16020
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

solved [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *petermad »

history.txt wrote:06.03.23 Added: New style directory history list which is no longer based on a Windows menu and supports quick search (32/64)
To reproduce:
Run TC in non-maximized state

Open the new history list (Alt+DownArrow)
Click on the desktop or another program window to remove focus from TC
The History list closes - as expected

Now - Open the new history list again
Right-click on the list to open the context menu.
Press Escape - the context menu is closed
Press Escape again - the history list is closed - as expected

Now - Open the new history list again
Right-click on the list to open the context menu.
Click on another program window that will cover TC's window
The context menu is now shown OVER the the other program's window

The best thing would be if the context menu is opened then both the context menu AND the history list should be closed when TC looses focus.
Last edited by petermad on 2023-05-10, 15:32 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *nice »

Open the new history list (Alt+DownArrow)

TC 10.52:
- can use keyboard arrows when holding Alt
- history list is closing when releasing alt

TC 11.00:
- can't use keyboard arrows when holding Alt
- quick search menu is open when releasing Alt
- quick search menu is closing when pressing Esc
- history list is closing when pressing Esc second time

i would not ask, who asked for the "new style history list", but now it is working "as fine as it should" (sorry, I lied)
Dennis_Stevens
Senior Member
Senior Member
Posts: 217
Joined: 2013-06-08, 16:16 UTC
Location: NRW, Germany

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *Dennis_Stevens »

petermad wrote: 2023-05-03, 20:27 UTC
history.txt wrote:06.03.23 Added: New style directory history list which is no longer based on a Windows menu and supports quick search (32/64)
To reproduce:
Now - Open the new history list again
Right-click on the list to open the context menu.
Click on another program window that will cover TC's window
The context menu is now shown OVER the the other program's window
Confirmed. The error occures even if you open the history list and after that move a window over TC.
#230412 Single User Licence
Commanding Win10 64bit totally with version 11
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50406
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *ghisler(Author) »

Thanks, I can confirm that. I will remove the history list, context menu and quick search when the user switches to a different program.
- can use keyboard arrows when holding Alt
- history list is closing when releasing alt
I didn't know that! I will add that also to the new history list. In order to add search, filtering, and context menu I had to replace the default menu with my own dialog, so I have to re-add all these features by hand.
Please let me know if you are missing any other functionality! The new dialog should have more features, not less. I will add all missing.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16020
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *petermad »

Please let me know if you are missing any other functionality!
It would be nice with a function in the context menu to Clear the list (delete history) - instead of having to press Shift+DEL on all items.
And maybe Save history could be put in the context menu too - for those who have disabled saving history on exit.

When the context menu is open, the shortcuts shown in the right side does not work - Of course ENTER can not be made to work because ENTER has to execute the command under the cursor in the context menu, but perhaps the other shortcuts (Shift+Enter, Ctrl+LEFT/RIGHT, Ctrl+Shift+P) could be made to work from the context menu?
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50406
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *ghisler(Author) »

It would be nice with a function in the context menu to Clear the list (delete history) - instead of having to press Shift+DEL on all items.
That would be quite risky, you could quickly lose a lot of entries. Just use Shift+Del.
And maybe Save history could be put in the context menu too - for those who have disabled saving history on exit.
Sounds like a good idea.
perhaps the other shortcuts (Shift+Enter, Ctrl+LEFT/RIGHT, Ctrl+Shift+P) could be made to work from the context menu?
It's a regular Windows context menu, so unfortunately not. They only work directly in the history list.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16020
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *petermad »

That would be quite risky, you could quickly lose a lot of entries. Just use Shift+Del.
Maybe with a confirmation box in between? During the years there have been many questions in the forum about how to clear the history, and the answer has always been to delete the [LeftHistory] and [RightHistory] sections in wincmd.ini manually.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50406
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *ghisler(Author) »

2nice
Could you clarify some of your comments for me, please? You wrote:
TC 10.52:
- can use keyboard arrows when holding Alt
I can confirm that and will add it.
- history list is closing when releasing alt
I cannot confirm that. I need to release Alt and then press it again to close the history in TC 10.52. Tested on Windows 7 and 11.
TC 11.00:
- can't use keyboard arrows when holding Alt
Confirmed.
- quick search menu is open when releasing Alt
Not confirmed. I can press Alt as many times as I want, it doesn't open quick search. Tested on Windows 7 and 11.
- quick search menu is closing when pressing Esc
Correct.
- history list is closing when pressing Esc second time
Correct, it also does this in TC 10.52.

So how did you get this strange Alt key behavior? Maybe it depends on the Windows version, or the language version?
Author of Total Commander
https://www.ghisler.com
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *nice »

- history list is closing when releasing alt
I cannot confirm that. I need to release Alt and then press it again to close the history in TC 10.52. Tested on Windows 7 and 11.
Try using Down arrow on your Numpad.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50406
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *ghisler(Author) »

That's crazy, I get the same wm_keydown and wm_keyup in both cases, but indeed the menu disappears when using the numpad. How am I supposed to simulate that? :(
Author of Total Commander
https://www.ghisler.com
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *Hacker »

Christian,
Check NumLock status? ¯\_(ツ)_/¯

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
nice
Junior Member
Junior Member
Posts: 84
Joined: 2018-03-12, 23:58 UTC

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *nice »

This is because holding Alt when pressing Numpad keys triggers Alt numpad input method.
User avatar
Hacker
Moderator
Moderator
Posts: 13142
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *Hacker »

nice,
Doesn't that work only when NumLock is on?

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
petermad
Power Member
Power Member
Posts: 16020
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.00b1] cannot escape new history list under certain circumstances

Post by *petermad »

history.txt wrote:04.05.23 Fixed: New history dialog: Always close history, quick search and context menu of history when switching to another application, and make history dialog a child window (32/64)
Confirmed fixed in TC 11.00b2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply