[TC 11.03] Search for | *\ with leading spaces

[white]

Search for files with name "a" or "b", do not search in subfolders:

Code: Select all

  a     b   | *\

Search for all files, do not search in subfolders:

Code: Select all

| *\

Search for all files, do not search in subfolders:

Code: Select all

 | *\

The last search text, containing 1 or more leading spaces, is not working.

[ghisler(Author)]

You need to put names with spaces in double quotes, e.g.
*.* | " *\"

[petermad]

2ghisler(Author)

I think White expects expects all leading or trailing spaces to be ignored if there are no quotes

[white]

You need to put names with spaces in double quotes, e.g.
*.* | " *\"

LOL, that's excluding traversing folders starting with a space. As I said I wanted to: "Search for all files, do not search in subfolders".

I think White expects expects all leading or trailing spaces to be ignored if there are no quotes

Exactly, the last 2 code blocks should do the same.

[jonathanpoulin]

If I can add to this topic...

Maybe it would help solving potential bugs.

Here are some use cases I tested:

1. Empty mask (i.e. blank Search field):

   Code: Select all

   Should returns all files/directories (working)

   ---

2. Empty (two double-quotes) mask:

   Code: Select all

   ""

   Should returns all files/directories as well (working)

   ---

3. Empty mask with empty exclude mask (i.e. pipe character in Search field):

   Code: Select all

   |

   Should returns all files/directories as well (NOT working)

   ---

4. Empty (two double-quotes) mask with empty exclude mask:

   Code: Select all

   ""|

   Should returns all files/directories as well (NOT working)

   ---

5. Empty (two double-quotes) mask with empty (two double-quotes) exclude mask:

   Code: Select all

   ""|""

   Should returns all files/directories as well (NOT working)

   ---

6. Empty (as spaces) mask with empty exclude mask:

   Code: Select all

     |          <=== 2 leading spaces

   Should returns all files/directories as well (NOT working)

   ---

7. Empty (as spaces) mask with empty (as spaces) exclude mask:

   Code: Select all

     |            <=== 2 leading/trailing spaces

   Should returns all files/directories as well (NOT working)

[white]

Here are some use cases I tested:

A pipe symbol doesn't change the search mode, so in this case the pipe is interpreted literally and not as a separator for an exclude section. Take a look at the example "Smith | txt" here: https://www.ghisler.ch/wiki/index.php?title=Search.

[JOUBE]

You need to put names with spaces in double quotes, e.g.
*.* | " *\"

LOL, that's excluding traversing folders starting with a space. As I said I wanted to: "Search for all files, do not search in subfolders".

It's OK as it is implemented now and doesn't need to be changed. So there's no reason to ridicule it.

Jou"That's only happened over the years on the forum when regulars got impatient and so on."be

[jonathanpoulin]

Here are some use cases I tested:

A pipe symbol doesn't change the search mode, so in this case the pipe is interpreted literally and not as a separator for an exclude section. Take a look at the example "Smith | txt" here: https://www.ghisler.ch/wiki/index.php?title=Search.

Ahh, ok I see. Sorry. I think I will keep the wiki open for a while! lol!

Shouldn't we adjust the .chm file with the wiki infos then?

So, my bullet points 3 to 7 of my previous post are invalid assumptions. That is okay the way it is implemented right now. Good!

[ghisler(Author)]

This should be fixed in Total Commander 11.50 beta 1, please check it!

17.07.24 Fixed: Find files: Ignore any leading and trailing spaces in wildcard searches except when they are in double quotes, e.g. *.txt *.docx now needs to be "*.txt " *.docx (32/64)

[white]

This should be fixed in Total Commander 11.50 beta 1, please check it!

Tested OK using TC 11.50b1 32-bit and 64-bit.

17.07.24 Fixed: Find files: Ignore any leading and trailing spaces in wildcard searches except when they are in double quotes, e.g. *.txt *.docx now needs to be "*.txt " *.docx (32/64)

The code:

Code: Select all

*.txt  *.docx

already did not work to find files with extension ".txt " (with trailing space), so your bug fix description is wrong. Spaces were already ignored, but not in all circumstances.

[ghisler(Author)]

What description would you suggest?

[white]

What description would you suggest?

Perhaps this:

17.07.24 Fixed: Find files: Spaces were not always ignored in wildcard searches when they were not in between double quotes (32/64)

[ghisler(Author)]

I have updated the description in 11.50 beta 2, please check!

[white]

I have updated the description in 11.50 beta 2, please check!

Confirmed.

Moderator message from: white » 2024-10-16, 14:45 UTC

Moved topic
» from TC11.x bug reports (English) to TC Fixed bugs