[TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

[TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *white »

  • Select menu option Configuration/Options and select category Zip packer
  • Press the Tab key repeatedly
  • When in the group box "Internal ZIP compression" the input field behind the option "other:" gets focus, the compression ratio is set to "other" and the Apply button is enabled.
(The same thing happens when you click on the input field.)

  • Select menu option Configuration/Options and select category 7zip packer
  • Press the Tab key repeatedly
  • When in the group box "7zip compression" the input field behind the option "other:" gets focus, the compression ratio is not set to "other" and the Apply button is enabled.
(The same thing happens when you click on the input field.)


In my opinion, when pressing Tab repeatedly nothing should change and the Apply button should remain disabled. (And when you click in the field and change nothing, nothing should happen.)
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *petermad »

In my opinion, when pressing Tab repeatedly nothing change and the Apply button should remain disabled.
I agree - and also when the "other" selection box gets focus the "other" radio button should also get focus as in the ZIP packer dialog
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *white »

petermad wrote: 2024-10-09, 21:54 UTC .. and also when the "other" selection box gets focus the "other" radio button should also get focus as in the ZIP packer dialog
Can't decipher this. Can you explain what you mean?
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *petermad »

Can't decipher this. Can you explain what you mean?
If I in the ZIP packer dialog for example have the option "maximum compression enabled (9)" and I tab past that option then in the ZIP packer dialog both the radio button "other" is enabled AND the selection box to the left of "(0 = none)" are selected.

In the 7Zip packer dialog ONLY the selection box is selected - the "maximum compression enabled (9)" is not un-selected, and the "other" button is not selected as it should be.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *white »

petermad wrote: 2024-10-09, 22:12 UTC If I in the ZIP packer dialog for example have the option "maximum compression enabled (9)" and I tab past that option then in the ZIP packer dialog both the radio button "other" is enabled AND the selection box to the left of "(0 = none)" are selected.

In the 7Zip packer dialog ONLY the selection box is selected - the "maximum compression enabled (9)" is not un-selected, and the "other" button is not selected as it should be.
But you agreed that pressing Tab repeatedly should not change anything and should not enable the Apply button. Now you disagree?

In my opinion which radio button is selected should not change when the input filed gets focus, but when the value in it changes. Similar to the "Limit tab title length to" option in the "Folder Tabs" category.

Or simply disable the input field when the "Other" radio button is not selected. That would be consistent with most options with a checkbox and a value (the "Limit tab title length to" option is an exception).
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *petermad »

Usually you shift between (and select) radio buttons with the arrow key - not tab, and if works that way for the first 3 compression options, but the "other" option is also selected with tab, an maybe that should not be so. So - yes, the way it works in the 7Zip configuration is the right way to do it.
Or simply disable the input field when the "Other" radio button is not selected.
That is a good idea
the "Limit tab title length to" option is an exception).
"Copy/Delete" -> "Use compatibility mode for the following drives" is another exception.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *ghisler(Author) »

I agree that the "other" radio button should only be checked when the value is changed by the user, either by typing a new value, or using the arrow buttons. I will change it.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *petermad »

2ghisler(Author)
And make sure the two dialogs behave the same way.
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50390
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *ghisler(Author) »

This should be fixed in 11.50 beta 2, please check!
Author of Total Commander
https://www.ghisler.com
User avatar
white
Power Member
Power Member
Posts: 5744
Joined: 2003-11-19, 08:16 UTC
Location: Netherlands

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *white »

HISTORY.TXT wrote:10.10.24 Fixed: Pressing Tab in Configuration - Options - ZIP packer would check option "other" when the cursor entered the edit box behind it. Changed to only check when the value is changed by the user, also on 7zip page (32/64)
Tested OK using TC 11.50b2 32-bit and 64-bit.

Moderator message from: white » 2024-10-16, 13:33 UTC

Moved topic
» from TC11.x bug reports (English) to TC Fixed bugs
User avatar
petermad
Power Member
Power Member
Posts: 15997
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Re: [TC 11.50b1] Pressing Tab in Zip packer and 7zip packer configuration dialogs

Post by *petermad »

Yes, Confirmed fixed and working identically for Zip and 7-Zip dialog in TC 11.50b2 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.51 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1391a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply