Menu With Icons.

Here you can propose new features, make suggestions etc.

Moderators: white, Hacker, petermad, Stefan2

User avatar
pdavit
Power Member
Power Member
Posts: 1529
Joined: 2003-02-05, 21:41 UTC
Location: Kavala -> Greece -> Europe -> Earth -> Solar System -> Milky Way -> Space
Contact:

Post by *pdavit »

Lefteous wrote:The new solution is actually even simpler then the previous because you just have to draw an icon instead of providing a bitmap.
This implies less overhead as well. We all know that Christian loves speed! ;-)

Great work of collaboration between the two Christians'! :P

Edited: Here's another "side effect" in my case: http://img214.imageshack.us/img214/4095/menusdj2.png (Tree entry as well. Not arrow pointed in pic)

Using WindowBlinds v5.01
"My only reason for still using M$ Window$ as an OS is the existence of Total Commander!"
Christian Ghisler Rules!!!
User avatar
petermad
Power Member
Power Member
Posts: 14811
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2pdavit
Try and download the demo again - that seems to be fixed in the latest version.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
pdavit
Power Member
Power Member
Posts: 1529
Joined: 2003-02-05, 21:41 UTC
Location: Kavala -> Greece -> Europe -> Earth -> Solar System -> Milky Way -> Space
Contact:

Post by *pdavit »

petermad wrote:Try and download the demo again - that seems to be fixed in the latest version.
Nop! Problem is still there! :-(
"My only reason for still using M$ Window$ as an OS is the existence of Total Commander!"
Christian Ghisler Rules!!!
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

@Lefteous:

Looks really nice BUT
if u have checkmarks but no Icons it looks ugly:
http://home.arcor.de/rosa.elefant/tc/pics/menu01.jpg
and what looks even uglier is Menus without Pics/Checkmarks whatever because of to big menu items without reason:
http://home.arcor.de/rosa.elefant/tc/pics/menu02.jpg


PS: when Icons are implemented into TC Leftous should be mentioned in the Credits :!:
Hoecker sie sind raus!
User avatar
pdavit
Power Member
Power Member
Posts: 1529
Joined: 2003-02-05, 21:41 UTC
Location: Kavala -> Greece -> Europe -> Earth -> Solar System -> Milky Way -> Space
Contact:

Post by *pdavit »

What if checkmarks are right-alligned? Is this possible?
"My only reason for still using M$ Window$ as an OS is the existence of Total Commander!"
Christian Ghisler Rules!!!
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

pdavit wrote:What if checkmarks are right-alligned? Is this possible?
It surly possible but Checkmarks and Dots should be on the left side :!: :-)
Hoecker sie sind raus!
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2pdavit
I guess it's a bug in Windowsblinds.

2Sir_SiLvA
You are right. It should be a bit better now:
http://www.lefteous.de/tc/archives/iconmenu_demo/iconmenu_demo_winapi.sqx
User avatar
Sir_SiLvA
Power Member
Power Member
Posts: 3300
Joined: 2003-05-06, 11:46 UTC

Post by *Sir_SiLvA »

Lefteous wrote:2Sir_SiLvA
You are right. It should be a bit better now:
http://www.lefteous.de/tc/archives/iconmenu_demo/iconmenu_demo_winapi.sqx
Yeah real good job just one thing left :D
http://home.arcor.de/rosa.elefant/tc/pics/menu03.jpg
MenuItem is now to big if theres 0 Checkmarks :)
Apart from that -> Time to build it into TC :D
Hoecker sie sind raus!
User avatar
majkinetor !
Power Member
Power Member
Posts: 1580
Joined: 2006-01-18, 07:56 UTC
Contact:

Post by *majkinetor ! »

Sir Silva wrote:Apart from that -> Time to build it into TC
Are you insane ?
Who needs icons in menus.
Habemus majkam!
User avatar
pdavit
Power Member
Power Member
Posts: 1529
Joined: 2003-02-05, 21:41 UTC
Location: Kavala -> Greece -> Europe -> Earth -> Solar System -> Milky Way -> Space
Contact:

Post by *pdavit »

majkinetor ! wrote:Who needs icons in menus.
I do! ;-) :P
"My only reason for still using M$ Window$ as an OS is the existence of Total Commander!"
Christian Ghisler Rules!!!
User avatar
majkinetor !
Power Member
Power Member
Posts: 1580
Joined: 2006-01-18, 07:56 UTC
Contact:

Post by *majkinetor ! »

2 pdavit
I guess you didn't understand... its a history thing


2 Leftious
I just set MFS_CHECKED
Why do you set this ? I frist thought it is to provide space for the icon but as you said that windows will resize the menu on its own, I am not sure now...
Habemus majkam!
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2Sir_SiLvA
MenuItem is now to big if theres 0 Checkmarks
Did you compare this to a standard menu? There is always an indent of about 20 pixels. The difference between my curent implementation and a standard menu shouldn't be more than 2 pixels - if any.

2majkinetor !
Why do you set this ?
msdn wrote:MFS_CHECKED
Checks the menu item.
User avatar
majkinetor !
Power Member
Power Member
Posts: 1580
Joined: 2006-01-18, 07:56 UTC
Contact:

Post by *majkinetor ! »

I see.

I thought it has something to do with the menu icons :)
Somehow the checkbitmap workaround keeps hanging in my head.

I suggested this fast and nice solution to the Chris at AHK hopping it will do the same as Ghisler with AHK menu command.

Thx.
Habemus majkam!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48093
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

2Lefteous
I found out about the ownerdraw icon mode too yesterday - very nice, almost perfect!

The only problem is with right to left languages like Arabic or hebrew: The checkmarks are correctly moved to the right side and the text is all right-aligned, but the icons remain on the left side. :(

Any ideas? To test it you can mirror the main menu like this:

Code: Select all

  fillchar(mii,sizeof(mii),#0);
  mii.cbsize:=sizeof(mii);
  mii.fmask:=MIIM_TYPE;
  mii.dwtypedata:=menuname2;
  mii.cch:=sizeof(menuname2);
  if GetMenuItemInfo(menuhandle,0,true,mii) then begin
    if mirrored then
      ftype2:=mii.ftype or MFT_RIGHTJUSTIFY or MFT_RIGHTORDER
    else
      ftype2:=mii.ftype and not (MFT_RIGHTJUSTIFY or MFT_RIGHTORDER);
    if ftype2<>mii.ftype then begin
      mii.ftype:=ftype2;
      SetMenuItemInfo(menuhandle,0,true,mii);
      DrawMenuBar(mainhandle);
    end;
  end;
Author of Total Commander
https://www.ghisler.com
User avatar
Lefteous
Power Member
Power Member
Posts: 9535
Joined: 2003-02-09, 01:18 UTC
Location: Germany
Contact:

Post by *Lefteous »

2ghisler(Author)
Sorry I currently don't see a way to control the placement of the icon using this approach. I really wonder why the icon are placed on the left side using these flags.
Post Reply