Solved [TC 8.01rc2 x64] Artifact in button

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC 8.01rc2 x64] Artifact in button

Post by *petermad »

27.06.12 Added: Show inplace rename confirmation button also in current dir bar (32/64)
If the button is placed to the left (InplaceOkButton=2), the 64bit version shows two dots (like a colon) to the right of the button.

See: http://madsenworld.dk/tcmd/inplacerenamebut.png

Testet with both Aero and Luna theme under Windows 7 x64.
Last edited by petermad on 2021-05-30, 16:02 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

2petermad
Why don't you like right position? It's more logical then left-aligned.
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2MaxX
I think the distance from the name to the button is too big when it is right aligned.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
MaxX
Power Member
Power Member
Posts: 1029
Joined: 2012-03-23, 18:15 UTC
Location: UA

Post by *MaxX »

2petermad
Have full-hd monitor, use 8pt fonts and still dont think so... :lol:
But really, there's a bug.
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Re: [TC 8.01rc2 x64] Artifact in button

Post by *umbra »

petermad wrote:If the button is placed to the left (InplaceOkButton=2), the 64bit version shows two dots (like a colon) to the right of the button.
I think it is a colon. And I don't think it's a platform specific issue. Lazarus just draws buttons, panels, ... a bit differently, that's why you see this specific symptom in TCx64 and not in TCx32.

Currently, when you start editing a path, on top of its panel, there is a textbox (or whatever) and now also the conformation button drawn. But the path panel (with the original path) is not completely hidden. You can see it and its original text in gaps - between the left border of panel and the textbox, between the textbox and the confirmation button and also between the confirmation button and the panel's right border (default layout).

You can prove it easily: open a directory with a path so long that it will fill up the path panel, double-click on the path panel to start editing it and then move the panel splitter to resize panels. Unlike the path panel, the editable textbox will not resize which will allow you to see the original path behind it.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

I think it is a colon.
I am not sure that it is. The distance between the two dots is smaller than the distance in the colon in the path box next to it.
path panel to start editing it and then move the panel splitter to resize panels.
Really weird things happen here when I expand the panel during editing of the path - the left side of the edit box and the newly expanded part have different background color.

Also with a clean ini file, where the button is right aligned, the button remains static when the file panel is expanded.

See: http://madsenworld.dk/tcmd/editpath.png - here with Windows 7 standard theme.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

The distance between the two dots is smaller than the distance in the colon in the path box next to it.
A font used in the path panel is bold while a font used in the editbox is not.
the left side of the edit box and the newly expanded part have different background color.

Also with a clean ini file, where the button is right aligned, the button remains static when the file panel is expanded.
The newly expanded part is not the editbox, it's the underlying path panel. When you resized a file panel, the path panel resized too, but the editbox drawn over it wasn't resized and so the confirmation button next to the edit box wasn't moved either.
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

A font used in the path panel is bold while a font used in the editbox is not.
Not here, I have bold font in both cases.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually what you see is the path which shines through.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14809
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Fixed in TC 8.01RC3 x64 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
umbra
Power Member
Power Member
Posts: 871
Joined: 2012-01-14, 20:41 UTC

Post by *umbra »

Thanks, the OK button works much more reliably now (TC 8.01 rc3).
Windows 7 Pro x64, Windows 10 Pro x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48088
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Yes, I moved the button outside of the path field, and reduced the size of that field.
Author of Total Commander
https://www.ghisler.com
Post Reply