Context menus hotkeys display

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

any ETA for your cool special menu customizations?
Not until the final version of TC 9.0 is out - things might change many times until then. But I am already working on it...
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
SailorMax
Member
Member
Posts: 121
Joined: 2007-03-15, 15:11 UTC

Post by *SailorMax »

Fixed in Beta2.
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

With Russian language file hotkeys are still displayed with extra space in 9.0b2.

Code: Select all

Ctrl +X
Alt +Enter
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Not confirmed fixed in TC9b2 when a lng file is used. :-(

The strings 5282, 5283 and 5284 from the Misc configuration dialog are reused for this, and that is why there is a space before the + sign.

It is not smart to reuse these strings since they might contain amperands for hotkeys, and they ar not necessarily spelled the same way as when they are used for showing shortcut keys in menus.

In Danish it now shows as for example Control +X where it should be Ctrl+X when used in a menu.

We have to get 3 new string for this use or one multistring like string 1653
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Skif_off
Member
Member
Posts: 132
Joined: 2013-09-30, 13:13 UTC

Post by *Skif_off »

2ghisler(Author)
Is it possible to add option to enable/disable show hotkeys in the right click context menu? I think only via wincmd.ini would be sufficient (it's not the option that user needs to be changed frequently).
User avatar
sas2000
Power Member
Power Member
Posts: 682
Joined: 2003-02-07, 04:32 UTC
Location: Galiza

Post by *sas2000 »

Skif_off wrote:2ghisler(Author)
Is it possible to add option to enable/disable show hotkeys in the right click context menu? I think only via wincmd.ini would be sufficient (it's not the option that user needs to be changed frequently).
Support
User avatar
MVV
Power Member
Power Member
Posts: 8702
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

In 9.0b3 there are no more extra space in hotkeys! :)
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

But the string 5282 is still reused - and It is NOT correct translation to use Control for the right click men it has to be Ctrl.

Of course I could change string 5282 to "Ctrl" but it har always been Control - also in English.

I think it is wrong to reuse strings in other contexts, where you cannot be sure that the translation will be the same. So I don't consider this bug fixed :-(
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Actually it's the same, 5282 also refers to the physical key. Maybe 5282 is translated incorrectly?
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

English .lng file:
5282="Control +"

Danish .lng file:
5282="Control +"

Control anywhere else in English (and Danish) .lng and mnu file for shortcuts: Ctrl

I just ask for the possibility for making a consistent translation.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Dalai
Power Member
Power Member
Posts: 9409
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

petermad wrote:But the string 5282 is still reused - and It is NOT correct translation to use Control for the right click men it has to be Ctrl.
TC9 beta3 shows "Ctrl+X" when I open the context menu of any file on my Win7 x64 VM. Did I miss something?

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2Dalai

Which language file are you using and what is the text in your Configuration -> Options -> Misc. -> Redefine hotkeys (Keyboard remapping) -> Control +

Notice string 5282 has been changed in the internal English dialog from being "Control" up until TC9b2 to "Ctrl" in TC9b3 - Ghisler is just cutting it short ;-)

EDIT, It is not really string 5282 in internal English that has been changed in beta3, because it still shows "Control" in the Misc. Config dialog, but Ctrl in the context menu - so for internal English two different strings are used - but not so if an external .lng file is used.
Last edited by petermad on 2016-06-24, 21:27 UTC, edited 2 times in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Dalai
Power Member
Power Member
Posts: 9409
Joined: 2005-01-28, 22:17 UTC
Location: Meiningen (Südthüringen)

Post by *Dalai »

petermad wrote:Which language file are you using
None, so internal English.
[...] and what is the text in your Configuration -> Options -> Misc. -> Redefine hotkeys (Keyboard remapping) -> Control +
Control +.
Notice string 5282 has been changed in the internal English dialog from being "Control" up until TC9b2 to "Ctrl" in TC9b3
I didn't test ealier betas.

Regards
Dalai
#101164 Personal licence
Ryzen 5 2600, 16 GiB RAM, ASUS Prime X370-A, Win7 x64

Plugins: Services2, Startups, CertificateInfo, SignatureInfo, LineBreakInfo - Download-Mirror
User avatar
petermad
Power Member
Power Member
Posts: 14826
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

2ghisler(Author)

Another drawback of reusing strings 5282, 5283, 5284 and 5299 for the contest menu is that there can be hotkeys attached to those strings, and those hotkeys are displayed but inactive/inappropiate/replicated in the contect menu.

See: http://madsenworld.dk/tcmd/underlinecontext.png

So please provide a new string xxxx="Ctrl;Alt;Shift;Win" that can be used for this purpose (and many others) and can be properly translated.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48118
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, currently not planned. TC does remove the hotkeys from them when re-using them.
Author of Total Commander
https://www.ghisler.com
Post Reply