[BUG] pluginbasedir setting causes wrong path proposal

[icfu]

If pluginbasedir points to %appdata%\Total Commander\Plugins, I get wrong path proposals for lister plugins. TC proposes to put them in the WFX directory instead!

If I change the path, for example by exchanging Total Commander with TotalCommander or Cotal Tommander, the problem is no more and the correct WLX dir is proposed.

This is reproducable here!

Icfu

[Flint]

Cannot confirm. Tested on TC 6.55, WinXP SP2 with fresh INI containing only the pluginbasedir key; no other plugins were installed in thу folder specified (%appdata%\Total Commander\Plugins).

Such a problem occurs, when you have some plugin in the wrong subfolder of the Plugins folder. I have had the similar problem that was caused by the presence of Imagine.wcx in the same folder that contained Imagine.wlx. Check it, please...

[icfu]

Well, you are right, I can workaround the problem if I rename EventLog.wlx to EventLog.bak!

Anyway, what a strange detection routine is that?

Edited:
I had overlooked parts of your answer, sorry. Indeed TC doesn't parse wincmd.ini to find out if a plugin exists but it parses the real file system.

I don't understand that system obviously. I mean, I tell TC WHERE to put plugins with the setting pluginbasedir! So, if a file has the extension WLX and is NOT already installed, TC should just put it in pluginbasedirpath\WLX, right?

Why does TC take the path given by the first WLX file it finds in the file system instead? Makes no sense to me.



Icfu

[XPEHOPE3KA]

Read this thread through.

[icfu]

And now? No new info there. Do you mean anything specific?

Icfu

[petermad]

if a file has the extension WLX and is NOT already installed, TC should just put it in pluginbasedirpath\WLX

Or in:
pluginbasedirpath\Lister Plugins
or:
pluginbasedirpath\Lister
etc.

Why do you expect TC to use a subdir called WLX ?

[Hacker]

petermad,
Do a recommend folders structure for plugins exists? (sic)

HTH
Roman

[petermad]

2Hacker

Do a recommend folders structure for plugins exists? (sic)

I know that thread very well (that's why I refer to it here)

Even if a recommended structure is endorsed by Ghisler, it doesn't mean that the structure is mandatory. That is also the reason that TC searches the pluginbasedirpath for plugins of the same type as the one being installed. And that is also why you can't expect any names as default for the subdirs of pluginbasedir.

I guess that this whole issue won't be solved until TC is provided with (optional) variables for plugin subdirs (wlxpluginbasedir, wcxpluginbasedir etc.).

[icfu]

ghisler could solve that prob pretty easily:
He should not scan the file system but the corresponding section in wincmd.ini!

So, if a lister plugin is to be installed, he only needs to do an INI read of section [ListerPlugins] and then take the path which most of the entries have there. To decide which path is "most", he can read three, five or any other bigger number to decide, that's really no big deal.

It just makes no sense at all to parse the file system and then stick with the first find, this is not very thoughtful.

Of course, it would be much better if all plugin types would have a separate pluginbasedir that could be specified.

Icfu

[ghisler(Author)]

ghisler could solve that prob pretty easily:
He should not scan the file system but the corresponding section in wincmd.ini!

Unfortunately that wouldn't help at all as long as there are plugin packages containing multiple plugin types in the same directory...

[icfu]

This is why I have proposed to scan more than one entry. Have you stopped reading after that quote?

Anyway, the problem gets autosolved if you take the proposal from the other thread:
pluginbasedirWCX
pluginbasedirWLX
etc...

So, check for the plugin occurence in all of these paths and it it's not there, take the plugin type specific base path.

The result would be no more false detections and more comfort when installing.

Icfu