[bug] Buttonbar Path

English support forum

Moderators: Hacker, petermad, Stefan2, white

Post Reply
790
Junior Member
Junior Member
Posts: 31
Joined: 2009-04-22, 18:27 UTC

[bug] Buttonbar Path

Post by *790 »

I have in wincmd.ini:
Buttonbar=%COMMANDER_PATH%\Basic.bar
Then I want to change one of my many toolbars.

Change button bar:
Button bar >> (browse..).
Choose a different panel, make changes.
Again: Button bar >> (browse..).
Asks "Save?" , click "yes"
Asks about "make this BB the new main BB?" click "no"
Choose the main Basic.bar.
Again about "main BB?" click "yes"

...and Buttonbar=%COMMANDER_PATH%\Basic.bar
immediately changed to
Buttonbar=D:\TotalCMD\Basic.bar

It`s very bad! Always I need change it in other comps! Please FIX it.
TC 11.03, Win10x64
User avatar
petermad
Power Member
Power Member
Posts: 16147
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Well, it is hardly a bug, but an inconvenience.

But, I support your request for keeping %COMMANDER_PATH%, if once set for this option - also when changing to another bar located anywere under %COMMANDER_PATH%.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
790
Junior Member
Junior Member
Posts: 31
Joined: 2009-04-22, 18:27 UTC

Post by *790 »

Also I understand, it`s not a serious bug, but maybe it's time to fix it?
TC 11.03, Win10x64
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50930
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Sorry, TC cannot know when you want variables, and which, and when not. Just choose "No", because then the path is not changed.
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 16147
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Sorry, TC cannot know when you want variables
I think that if a variable is already used in wincmd.ini, TC should be able to recognize that, and continue to use the same variable when the buttonbar is changed, just as TC does with plugins.
License #524 (1994)
Danish Total Commander Translator
TC 11.55rc4 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1393a
TC 3.60b4 on Android 6, 13, 14
TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

Sure, would just need to do a search replace on the new path.

If old path contains an Environment Variable,
--> Expand Variable.
If new path matches the expanded variable,
--> Replace matching path with Environment Variable,
--> Confirm Dialog: Use Full Path, or Path with EV.
*BLINK* TC9 Added WM_COPYDATA and WM_USER queries for scripting.
790
Junior Member
Junior Member
Posts: 31
Joined: 2009-04-22, 18:27 UTC

Post by *790 »

ghisler(Author) wrote:Just choose "No", because then the path is not changed.
Oh it's amazing! Choose YES - the toolbar will be main, choose NO - also, the toolbar will be main! What is sense of asking? :D
TC 11.03, Win10x64
User avatar
Balderstrom
Power Member
Power Member
Posts: 2148
Joined: 2005-10-11, 10:10 UTC

Post by *Balderstrom »

The other option would be yet another ini config setting:

Code: Select all

ButtonBarPath=%TCData%\GUI\Toolbars
Then
1) TC would store the path relative to the "ButtonBarPath" - So long as the new toolbar is contained within that path,
2) Otherwise an absolute path is stored.

Further, the Change Bar dialog could have a button to switch to the "ButtonBarPath" if the current bar is an absolute path: to the right/or left of the current [>>] button.
*BLINK* TC9 Added WM_COPYDATA and WM_USER queries for scripting.
User avatar
Hacker
Moderator
Moderator
Posts: 13144
Joined: 2003-02-06, 14:56 UTC
Location: Bratislava, Slovakia

Post by *Hacker »

790,
Choose YES - the toolbar will be main, choose NO - also, the toolbar will be main! What is sense of asking?
It will not be main but it will remain being shown. After a restart of TC the original main bar should be shown by default.

Roman
Mal angenommen, du drückst Strg+F, wählst die FTP-Verbindung (mit gespeichertem Passwort), klickst aber nicht auf Verbinden, sondern fällst tot um.
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

790 wrote:
ghisler(Author) wrote:Just choose "No", because then the path is not changed.
Oh it's amazing! Choose YES - the toolbar will be main, choose NO - also, the toolbar will be main! What is sense of asking? :D
If you click No, TC won't write path to this bar into Buttonbar parameter in wincmd.ini's [Buttonbar] section.
Post Reply