Solved [TC9b3] Missing handling of long vertical button bars

Bug reports will be moved here when the described bug has been fixed

Moderators: white, Hacker, petermad, Stefan2

Post Reply
User avatar
petermad
Power Member
Power Member
Posts: 14889
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Solved [TC9b3] Missing handling of long vertical button bars

Post by *petermad »

If you load a vertical buttonbar with more buttons that can fit the visible area of the bar, there is no way to se the rest of the buttons.

We need a way to scroll the bar, either with mouse wheel or scroll buttons in top/bottom of the bar - or both. In case of scroll buttons they should only be visible when needed, not for short button bars that fit.
Last edited by petermad on 2021-05-30, 12:10 UTC, edited 1 time in total.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
ts4242
Power Member
Power Member
Posts: 2081
Joined: 2004-02-02, 20:08 UTC
Contact:

Post by *ts4242 »

I suggest showing a small button with icon of drop down arrow or 3 dots to show the hidden buttons as sub-bar
User avatar
petermad
Power Member
Power Member
Posts: 14889
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

In TC9b4 there now is an arrow icon at the end of long bars. If I just even hover this button in TC9b4 64bit I get an error sound at TC is closed down without any error message

The 32 bit version gives this message:
---------------------------
Total Commander 9.0ß4
---------------------------
Access violation at address 005E897C. Write of address 041907AB.
Access violation at address 005E897C. Write of address 041907AB
Windows 7 SP1 6.1 (Build 7601), base: 00400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Windows exception: C0000005
Stack trace:
005E897C
005E897A 005E8BE0 005E1CA6 00446DF5 00448DB2 >00426058
00448357 00426058 0042B73C 0042B7D8
Raw:
005E897A 005E8BE0 005E1CA6 00446DF5 00449081 00448422
00448DB2 00426058 00448357 00426058 0042B73C 0042B7D8
0042B992
Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Ja Nej
---------------------------
It does NOT appear with a clean ini-file - I seem to have narrowed the cause down to these parameters:

Code: Select all

[ButtonbarVertical]
Buttonheight=23
FlatIcons=0
If I change buttonheight to 29 I get this error message in TC9b4 64bit
---------------------------
Total Commander 9.0ß4
---------------------------
Access violation.
Access violation
Windows 7 SP1 6.1 (Build 7601), base: 0400000

Please report this error to the Author, with a description
of what you were doing when this error occurred!

Stack trace (x64):99D729
99DAA9 992F47 40F3BD 81A4A0 80EE73 909261 84CE0F 77529C11
440233 4406C1 77D40C 440667 404875
Press Ctrl+C to copy this report!
Continue execution?
---------------------------
Ja Nej
---------------------------
If I change FlatIcons to 1 everything works OK

There seem to be more to it than just FlatIcons=0 - but I haven't found out yet what it is.
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
User avatar
chandragor
Member
Member
Posts: 126
Joined: 2005-06-01, 10:10 UTC
Location: Italy

Post by *chandragor »

I can confirm the bug in TC9b4, both 32 bits and 64 bits.

It is not only the FlatIcons entry but the XPstyle too. If any one of them is 0 (or unchecked in the vertical bar settings) we have the same behaviour described by petermad
Happy owner of license #12422 since 1997
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 48185
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks, ButtonHeight=23 triggers it here - no problem with ButtonHeight=24...
Author of Total Commander
https://www.ghisler.com
User avatar
petermad
Power Member
Power Member
Posts: 14889
Joined: 2003-02-05, 20:24 UTC
Location: Denmark
Contact:

Post by *petermad »

Confirmed fixed in TC9b5 :-)
License #524 (1994)
Danish Total Commander Translator
TC 11.03 32+64bit on Win XP 32bit & Win 7, 8.1 & 10 (22H2) 64bit, 'Everything' 1.5.0.1371a
TC 3.50 on Android 6 & 13
Try: TC Extended Menus | TC Languagebar | TC Dark Help | PHSM-Calendar
Post Reply