[8.0ß2-x64] Hotkeys in SyncDirs context menu right-aligned

[ghisler(Author)]

Great, thanks!

[petermad]

Confirmed that the hotkeys are now showed in TC 8.0b4 with Luna theme - But the hotkeys are still right aligned, and the menus doesn't look alike in the 32bit and the 64bit version.

Here is how it looks in five different setups:

TC 8.0b4 x64 under Win 7 x64 - classic view: http://madsenworld.dk/tcmd/synccontextx64classic.png
TC 8.0b4 32bit under Win 7 x64 - classic view: http://madsenworld.dk/tcmd/synccontextx86classic.png

TC 8.0b4 x64 under Win 7 x64 - themed: http://madsenworld.dk/tcmd/synccontextx64theme.png
TC 8.0b4 32bit under Win 7 x64 - themed: http://madsenworld.dk/tcmd/synccontextx86theme.png

TC 8.0b4 32bit under Win XP 32bit - themed: http://madsenworld.dk/tcmd/synccontextx86xptheme.png

Notice how TC x64 shows a much narrower menu than TC 32bit and notice that only TC 32bit shows right alligned hotkeys and under Win 7 x64 only in classic view.

I would suggest that the width of the menu is increased in the x64 version (both classic and themed) so it matches the 32bit version - otherwise it looks like there is a risk, that the hotkey text and the menu text may overlap for some languages - it almost does in Danish for the hotkey "Ctrl+F3 / Dobbeltklik".

[Flint]

But the hotkeys are still right aligned

Christian commented on this here.

[petermad]

Christian commented on this here.

Fair enough - I really don't mind right aligned hotkeys, but this report was about this.

But I still think the sync menu is too narrow in the x64 version (specially in classic view) as you might agree on when looking at http://madsenworld.dk/tcmd/synccontextx64classic.png where the hotkeys and the menu are overlapping.

[Flint]

But I still think the sync menu is too narrow in the x64 version (specially in classic view) as you might agree on when looking at http://madsenworld.dk/tcmd/synccontextx64classic.png where the hotkeys and the menu are overlapping.

Yes, I think the width requires increasing.

[Sob]

But I still think the sync menu is too narrow in the x64 version...

It's Lazarus menu and it calculates the width by simply going through all items and asking for length of one string consisting of caption, two spaces and shortcut/hotkey text. While the correct behaviour is to take longest of all captions plus some spacing plus longest of all shortcut texts. That way the columns for captions and shortcuts don't overlap.

I already posted possible solution. But I understand that maintaining separate version of LCL for TC is not the best thing and the less changes there are, the better it is.

I thought I wrote it already in other thread, but it seem it wasn't saved for some reason. Rather than messing with Lazarus menus, it would be best to handle them same way as e.g. context menu for tabs in main window. Check that one with any Windows version and/or theme, it's perfect everywhere. And it should work for all menus without images that don't need owner-drawing, so all except the main menu and Show as menu buttonbars. Once and for all solution.