[x64] Two-lined main menu has wrong background

Flint · Post by *Flint » 2012-06-25, 16:17 UTC

Make the main TC window more narrow so that the "Help" menu item moved to the second line. Then background of this second line is drawn incorrectly, see screenshot:
http://gora.7zsfx.info/test/tc801rc1.PNG

In 32-bit version background is fine.

umbra · Post by *umbra » 2012-06-25, 16:21 UTC

Confirmed.

Post by *petermad » 2012-06-25, 20:59 UTC

Confirmed under Windows 7 with standard Windows Aero theme.

But, in 64bit TC you can disable the themed menu (XPthemeBg=0) - that doesn't work for 32bit TC under Windows 7 (it works under Windows XP).

Sob · Post by *Sob » 2012-06-25, 22:44 UTC

64-bit version = menubar drawn by Lazarus. And if I remember correctly, right-aligned Help menu is deprecated since Windows 95, so it's quite possible that no one ever tested it. :)

Post by *ghisler(Author) » 2012-06-28, 13:40 UTC

I guess so too - I will check the library code whether I can fix it.

sztihamer · Post by *sztihamer » 2012-06-29, 11:52 UTC

I can confirm that this bug has been fixed in version 8.0RC2.
Screenshot: http://i.imgur.com/0EOXC.png

Flint · Post by *Flint » 2012-06-29, 12:32 UTC

Confirm fixed.

Post by *petermad » 2012-06-29, 14:01 UTC

I can confirm that the bug with two lined menu background is fixed in TC 8.01RC2 x64.

But I still canNOT disable themed background for the menu itself in the 32 bit version under Windows 7 - it works under Windows XP, and it woks for the background under the button bar and the drive button bar also under Windows 7, but NOT for the menu - the menu stays themed with TC 32bit under Windows 7 - despite the setting of XPthemeBg.

Post by *ghisler(Author) » 2012-06-29, 15:09 UTC

Thanks for confirming the fix!

I'm sorry, the Lazarus libary doesn't currently offer a way to disable the menu background.

Post by *petermad » 2012-06-29, 18:03 UTC

I'm sorry, the Lazarus libary doesn't currently offer a way to disable the menu background.

I am talking about the 32bit version not being able to disable the menu background - so no Lazarus involment here!

The menu looks the same in my 32bit version (under Windows 7 x64) whether or not I have disabled "Configuration" -> "Options..." -> "Layout" -> "Windows XP theme background (menu+all bars)"

And actually - toggeling "Windows XP theme background (menu+all bars)" does work OK in the x64 version!

You can see the differencies as I see them here: http://madsenworld.dk/tcmd/xpthemebg.png

I expected snapshot D to look like B and I to look like G. Notice I am only referring to the look of the background of the menu bar - not the button bar or the drive button bar.

umbra · Post by *umbra » 2012-06-30, 16:06 UTC

The original bug is fixed.

2petermad
This issue has been mentioned a few times already.
http://www.ghisler.ch/board/viewtopic.php?t=33718
http://www.ghisler.ch/board/viewtopic.php?t=34337
Always with the same answer, that it's caused by a difference between Lazarus and Delphi.

Post by *petermad » 2012-07-01, 05:28 UTC

But the interesting thing is that it works for 32bit TC under Win XP 32bit, but not under Win 7 64bit - so the SAME version of TC (the 32bit) works differently under different OS'es - that seems buggy to me.

It also seems peculiar that it is possible to enable an extra feature, but that you cannot disable it! - I could understand it if it was the other way around.

umbra · Post by *umbra » 2012-07-01, 07:06 UTC

I'm not a Delphi programmer, so I don't know how it works with standard Windows controls like Buttons, ToolBars, ComboBoxes, ..., but I doubt it's using ones that are provided by Windows. These controls are not themed properly in TCx32 and this issue seems just like another example of it. Maybe they were tested with the old XP's theming system but not with new Aero-type themes.

sztihamer · Post by *sztihamer » 2012-07-01, 10:31 UTC

Remember that the 32bit version of Total Commander is still built with Borland Delphi 2 which was released in 1996. That was the first version that supported 32bit Windows environments if I remember correctly. Delphi 2 is great because it generates small and fast code, but there are some drawbacks like the ones petermad has.

Sob · Post by *Sob » 2012-07-01, 15:12 UTC

It also seems peculiar that it is possible to enable an extra feature, but that you cannot disable it! - I could understand it if it was the other way around.

Actually, it kind of is the other way around. :) When themes are enabled in Windows, then themed menus are standard and non-themed ones are extra feature. Take any program with standard menu (not drawn by program itself) - it does not have to support themes at all - and it will still have themed menu. Unlike for buttons and other controls, system does use themes for menus in all programs by default.

But the interesting thing is that it works for 32bit TC under Win XP 32bit, but not under Win 7 64bit - so the SAME version of TC (the 32bit) works differently under different OS'es - that seems buggy to me.

In fact, it does not work in XP either. It just seems it does.

32-bit TC uses native menu, but with one exception and it's the gradient with XP's Luna theme. Take a look at Notepad, no gradient there and it's like native menu looks like. Yes, Explorer does have gradient, but it's just one of many examples how great MS is with violating own paradigms. But since it does look better together with toolbar's gradient, TC does it too. And when you turn it off, TC just reverts to standard menu (everything drawn by system).

With your Luna theme on Windows 7, you probably have the default system menu in 32-bit TC all the time (I assume that drawing own gradient is active only on XP). But the difference here is how default menu looks like. Again, check Notepad. Here the gradient is by default. So native menu in TC means menu with gradient.