[8.51a] Bad copying from WFX to archive
Moderators: Hacker, petermad, Stefan2, white
[8.51a] Bad copying from WFX to archive
Discovered here.
I was able to reproduce this bug while copying any file from my Virtual Panel plugin to a subfolder of ZIP-archive.
When I use F5 to add file to archive, TC suggests archive root as target location, so file is added to archive root instead of opened folder.
When I do drag-n-drop, TC suggests an archive subdirectory in the form X:\archive.zip\dir\ and shows a error (perhaps because archive.zip exists as a file and not as a folder).
But if I alter path after drag-n-drop to X:\archive.zip/dir\ (notice forward slash after archive path), file is added to expected folder!
So fix should be the following:
1. Use forward slash as a divider between archive name and inner archive path.
2. TC should append forward slash and inner archive path to archive name on F5 just like on drag-n-drop.
I was able to reproduce this bug while copying any file from my Virtual Panel plugin to a subfolder of ZIP-archive.
When I use F5 to add file to archive, TC suggests archive root as target location, so file is added to archive root instead of opened folder.
When I do drag-n-drop, TC suggests an archive subdirectory in the form X:\archive.zip\dir\ and shows a error (perhaps because archive.zip exists as a file and not as a folder).
But if I alter path after drag-n-drop to X:\archive.zip/dir\ (notice forward slash after archive path), file is added to expected folder!
So fix should be the following:
1. Use forward slash as a divider between archive name and inner archive path.
2. TC should append forward slash and inner archive path to archive name on F5 just like on drag-n-drop.
Re: [8.51a] Bad copying from WFX to archive
If you edit the F5 proposed destination, like[face=courier] zip:C:\My.zip/Dir\Dest\[/face] you can put file in the archive on the right folder.MVV wrote:Discovered here.
When I use F5 to add file to archive, TC suggests archive root as target location, so file is added to archive root instead of opened folder.
.
So you detected two bugs :
1) the drag and drop is not consistent with F5
2) F5 destination is not well proposed in case of archive with virtual folder
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Maybe the following two checkboxes are not checked both:
- Also pack path names (only recursed)
- Recursively pack subdirectories
- Also pack path names (only recursed)
- Recursively pack subdirectories
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
Unfortunately that's not so easy to fix, so it was postponed to 9.0.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact:
This should be fixed in TC 8.52 RC1, please test it! I may not have covered all possible cases, but the most common (F5 and Drag&Drop-Copy) should work.
Author of Total Commander
https://www.ghisler.com
https://www.ghisler.com
- ghisler(Author)
- Site Admin
- Posts: 50541
- Joined: 2003-02-04, 09:46 UTC
- Location: Switzerland
- Contact: