[8.51a] Bad copying from WFX to archive

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

Post Reply
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

[8.51a] Bad copying from WFX to archive

Post by *MVV »

Discovered here.

I was able to reproduce this bug while copying any file from my Virtual Panel plugin to a subfolder of ZIP-archive.

When I use F5 to add file to archive, TC suggests archive root as target location, so file is added to archive root instead of opened folder.

When I do drag-n-drop, TC suggests an archive subdirectory in the form X:\archive.zip\dir\ and shows a error (perhaps because archive.zip exists as a file and not as a folder).

But if I alter path after drag-n-drop to X:\archive.zip/dir\ (notice forward slash after archive path), file is added to expected folder!

So fix should be the following:
1. Use forward slash as a divider between archive name and inner archive path.
2. TC should append forward slash and inner archive path to archive name on F5 just like on drag-n-drop.
User avatar
nsp
Power Member
Power Member
Posts: 1918
Joined: 2005-12-04, 08:39 UTC
Location: Lyon (FRANCE)
Contact:

Re: [8.51a] Bad copying from WFX to archive

Post by *nsp »

MVV wrote:Discovered here.

When I use F5 to add file to archive, TC suggests archive root as target location, so file is added to archive root instead of opened folder.
.
If you edit the F5 proposed destination, like[face=courier] zip:C:\My.zip/Dir\Dest\[/face] you can put file in the archive on the right folder.

So you detected two bugs :
1) the drag and drop is not consistent with F5
2) F5 destination is not well proposed in case of archive with virtual folder
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Yes, and both bugs are mentioned.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Maybe the following two checkboxes are not checked both:
- Also pack path names (only recursed)
- Recursively pack subdirectories
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

ghisler,
No options changed between tests, F5 and drag should work in the same way (why not?).
And, TC does append path inside archive but it does append it in the wrong way (using backslash instead of forward one).
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Still here in 8.52b1.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Unfortunately that's not so easy to fix, so it was postponed to 9.0.
Author of Total Commander
https://www.ghisler.com
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

This should be fixed in TC 8.52 RC1, please test it! I may not have covered all possible cases, but the most common (F5 and Drag&Drop-Copy) should work.
Author of Total Commander
https://www.ghisler.com
User avatar
MVV
Power Member
Power Member
Posts: 8711
Joined: 2008-08-03, 12:51 UTC
Location: Russian Federation

Post by *MVV »

Both test cases work fine in TC 8.52rc1, copying via F5 and via drag-n-drop from FS plugin to a subfolder of an archive: TC suggests correct inner path and packs files as expected.
Thank you!
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50541
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Post by *ghisler(Author) »

Thanks!
Author of Total Commander
https://www.ghisler.com
Post Reply