Problem with external 7z in 11.50b7

Bug reports will be moved here when the described bug has been fixed

Moderators: Hacker, petermad, Stefan2, white

AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Problem with external 7z in 11.50b7

Post by *AkulaBig »

With the internal packer and total7zip unchecked, that is, when using an external packer. Does not delete from an encrypted archive. It does not add both encrypted and unencrypted archives to the subdirectory.
More. I registered 7z through the Packer section. If the Use Total7z checkbox is not checked, it is impossible to add a file to the archive subfolder.
When replacing a file from a subfolder into an archive, the internal packer does not replace the file, but adds the full subfolder to the archive. You need to disable the save paths checkbox. I just don't understand if this is a bug or a feature. That's why I didn't write about it.
If it matters, I use 7zG.exe.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

Delete from encrypted:
Looks like a bug in 7zg.exe, it should ask for a password if it needs one. I will check whether I can add a switch for that.

Add to subdir: 7zg.exe does not have any switch to add files to a subdirectory. Both total7zip and TC handle this internally.
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

Thank you for your attention. I am waiting for your decision on password-protected archives.
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

Sorry for the offtopic. Do you plan to enable the -slp option in the internal 7z packer? This would immediately solve all the problems.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

The 7z.dll has am exported function SetLargePageMode(). However, this is irreversible - you could not set it for large files only, so it would then allocate huge buffers even when packing just a small file of a few bytes. The only way to reverse it would be to unload the dll, but this isn't possible when other pack operations are active in the background. Why do you think that SetLargePageMode would solve your problems?
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-24, 08:36 UTC Why do you think that SetLargePageMode would solve your problems?
See what a huge speed increase you get when using large pages:
[img]https://i.ibb.co/183zZ5f/7z-GSlp.png[/img]
[img]https://i.ibb.co/KXJH8D2/7z-GSlp.png[/img]
[img]https://i.ibb.co/zZPxgr7/7z-G-Slp.png[/img]
[img]https://i.ibb.co/jyW1bMz/7z-G-Slp.png[/img]
I tried packing small files with and without slp. The result is the same. The size has not changed, the speed has increased.
I solved the problems with deleting from encrypted archives and adding files to subfolders. But now for this I had to use 1. External archiver to be able to use the -slp option. 2. Separate archiver in the [PackerPlugins] section via Total7zip. To add files to subfolders. 3.
Check the Use Total7zip for unpacking option in the TC 7z settings. It also affects the work of this ligament.
But all this functionality is available to the internal packer, except for using the -slp option. That is, its use by an internal packer will greatly simplify packaging setup. And remove 7zG, leaving only the 7z.dll libraries.
And for buttons and scripts use the small 7za.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

Here is a test version of tcbit7z supporting the switch -slp. Just put it in the "Extra parameters" field:
https://www.totalcommander.ch/beta/tcbit7z-slp.zip

I do not see any difference in speed, maybe you do?

Once the option has been set, it remains active while there are 7-Zip operations ongoing. tcbit7z unloads the dll when done, so you cannot pack one archive with -slp and one without at the SAME time.
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-25, 09:26 UTC I do not see any difference in speed, maybe you do?
No, I don't have any speed gain either. I even tried replacing the TC7z, TC7z64 libraries with libraries from 7z.
And the external archiver continues to show excellent results:
[img]https://i.ibb.co/N7j1yhy/2024-11-25-150753.png[/img]
[img]https://i.ibb.co/jRDrRVB/2024-11-25-151809.png[/img]
[img]https://i.ibb.co/6PVfR7q/2024-11-25-152628.png[/img]
[img]https://i.ibb.co/n7r6ry9/2024-11-25-153619.png[/img]
[img]https://i.ibb.co/6bsqhVQ/2024-11-25-154358.png[/img]
[img]https://i.ibb.co/nznsSbb/2024-11-25-154614.png[/img]
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

No idea what could be wrong, I checked in the debugger that SetLargePageMode in 7z.dll is in fact called and returns "success".
Author of Total Commander
https://www.ghisler.com
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-25, 11:11 UTC No idea what could be wrong, I checked in the debugger that SetLargePageMode in 7z.dll is in fact called and returns "success".
Hm. Does the exe file really affect this somehow? Okay, thanks for your time. So far I have found a crutch and will use it. If you can figure it out, that would be great. You can't, and that's how it works :)
Will you include this library in b8?
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

Yes, I will include this library in b8.

As I have described here:
viewtopic.php?p=464514#p464514
I didn't know that I have to enable the large page mode function system wide (7-zip help for -slp explains that "To install this feature, you must run the 7-Zip File Manager with administrator's rights at least once, close it, and then reboot the system.").

For now I will not try this because I don't know how I could turn it off.
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1166
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: Problem with external 7z in 11.50b7

Post by *MaxX »

2ghisler(Author)
You may use this one without running 7zfm

Code: Select all

REGEDIT4

[HKEY_CURRENT_USER\Software\7-Zip]
"LargePages"=dword:00000001
And remove this key to disable it
Ukrainian Total Commander Translator. Feedback and discuss.
User avatar
ghisler(Author)
Site Admin
Site Admin
Posts: 50386
Joined: 2003-02-04, 09:46 UTC
Location: Switzerland
Contact:

Re: Problem with external 7z in 11.50b7

Post by *ghisler(Author) »

2MaxX
I don't think that this is sufficient - it doesn't grant the user the lock page permission. It just makes -slp the default.
But I found a description on how to grant the right via security policy:
https://docs.oracle.com/en/database/oracle/oracle-database/19/ntqrf/granting-lock-pages-in-memory-privilege.html
Author of Total Commander
https://www.ghisler.com
User avatar
MaxX
Power Member
Power Member
Posts: 1166
Joined: 2012-03-23, 18:15 UTC
Location: UA

Re: Problem with external 7z in 11.50b7

Post by *MaxX »

I only mean the place where that gui option is stored.
Ukrainian Total Commander Translator. Feedback and discuss.
AkulaBig
Power Member
Power Member
Posts: 528
Joined: 2021-09-09, 17:28 UTC

Re: Problem with external 7z in 11.50b7

Post by *AkulaBig »

ghisler(Author) wrote: 2024-11-26, 08:46 UTC As I have described here:
Yes, users from our forum have already given me a link to this correspondence.
Post Reply